health check: also process .so on macOS #247
Conversation
To ensure python modules are linking with the correct libs
| install_name = nil | ||
|
|
||
| yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle)$' | xargs otool -L") do |line| | ||
| yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle|so)$' | xargs otool -L") do |line| |
There was a problem hiding this comment.
should we consider sth.so.1.2?
| yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle|so)$' | xargs otool -L") do |line| | |
| yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle|so|so\.*)$' | xargs otool -L") do |line| |
There was a problem hiding this comment.
I'm not sure, in theory there should still be a .so without version, and in the specific case of python modules, they aren't versioned... But let's see what this changes first
I fear that this change will break the macOS healtcheck and that we won't be able to merge it right away
|
What does the health check do? |
We want to prevent incompatible ABI from being shipped. Since it'll take some more weeks until we have feature parity, we have to extend the defense mechanism existing in the the current scripts. |
To ensure python modules are linking with the correct libs