Skip to content

health check: also process .so on macOS #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chouquette wants to merge 1 commit into
base: datadog-5.5.0
Choose a base branch
from
Open

health check: also process .so on macOS #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/omnibus/health_check.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def health_check_otool
bad_libs = {}
install_name = nil

yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle)$' | xargs otool -L") do |line|
yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle|so)$' | xargs otool -L") do |line|
Copy link

@rdesgroppes rdesgroppes Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider sth.so.1.2?

Suggested change
yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle|so)$' | xargs otool -L") do |line|
yield_shellout_results("find #{project.install_dir} -type f | egrep '\.(dylib|bundle|so|so\.*)$' | xargs otool -L") do |line|

Copy link
Author

@chouquette chouquette Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, in theory there should still be a .so without version, and in the specific case of python modules, they aren't versioned... But let's see what this changes first

I fear that this change will break the macOS healtcheck and that we won't be able to merge it right away

case line
when /^(.+):$/
current_library = Regexp.last_match[1]
Expand Down