This repository was archived by the owner on Sep 14, 2019. It is now read-only.
Add clamp to move speed when during auto and intake is up #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove repetition
made Lift extend PIDSubsystem and implemented the necessary methods for that (need to do spd --> voltage method though) made new command (UpdateLiftPosition) for continuous teleop PID --> default Lift command need to make commands for auto
implemented LiftToPosition, MoveLift, MoveLiftWithPID added buttons for the new commands (w/ some finagling for LiftToPosition params) see https://trello.com/c/7OOvkOJG/167-implement-pid-on-lift-encoder for details in checklist
these buttons should be used mostly for testing purposes right now but can be changed later for competition functionality if necessary
fixed enable/disable/stop (also added enable to the end() of MoveLift so it's ready and live when not using that non-PID command anymore changed getString in OI to be SmartDashboard. instead of Robot. but left my getString methods in there bc not doing any harm left end() in interrupted bc not really doing any harm got rid of spd --> voltage method and replaced it with a constant from Robot.getConst
https://trello.com/c/7OOvkOJG/167-implement-pid-on-lift-encoder made absolute setpoints used getHeight for everything deleted AutoLift bc obsolete deleted another missed unecessary enable
Lift auto implementation (EjectTo...'s)
set default lift max height reset lift enc in autoInit
implemented getLiftTimeConstant and methods in it for Lift still need to implement default constant values (using more math, see PIDMove constructor) commented out stuff in testPeriodic bc don't need them
for UpdateLiftPosition and LiftToPosition
https://github.com/DriverStationComputer/RobotCode2018.git into lift Conflicts: Robot2018/src/org/usfirst/frc/team199/Robot2018/Robot.java
lift: reverted to old UpdateLiftPos, etc; implemented command group AutoLift for auto functions of going to the ground in 2 stages intake: IntakeCube and OuttakeCube ran motors in reverse direction than what they should have
The problem was that StopIntake was called and the intake was stopped, but the IntakeCube command was still running so StopIntake only jerked it to a stop and then restarted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes driver station repo changes.