Karsten/serialized ipm touchups#2
Karsten/serialized ipm touchups#2Karsten1987 wants to merge 9 commits intoDensoADAS:dnae_adas/serialized_ipmfrom
Conversation
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
@DensoADAS please let me know if you guys can work with this. I would appreciate to have the Serializer and SerialiedMessage being part of Foxy as such. |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
I had to disable the The problem with this test currently is that I some messages gets destroyed on the stack: when enabling |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
| if (!std::is_same<MessageT, CallbackMessageT>::value && | ||
| !std::is_same<MessageT, rclcpp::SerializedMessage>::value && | ||
| !std::is_same<CallbackMessageT, rcl_serialized_message_t>::value) | ||
| !std::is_base_of<rcl_serialized_message_t, MessageT>::value) |
There was a problem hiding this comment.
I wasn't exactly sure why this check is happening. Also, I wouldn't compile if we check for the CallbackMessageT, which I believe is the right thing to check for though.
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
So I am at a state where the serialize to serialize communication work, however all others not. So the main critique I have for this PR is that it's adding always to id's to the intraprocess communication manager. And I think this should be possible to limit to one, given that it's the same publisher. |
This is still WIP, but essentially this is how I would envision to deal with the
SerializerandSerializedMessageclass.The tests currently don't run, because I still have to get my head around the actual intraprocess communication. There's a lot of memory corruption and BAD_ACCESS exit codes around the
contextin the tests.