Skip to content

LIMS-2103: Display message for eBIC shipments if they try to access shipments#1039

Open
gfrn wants to merge 4 commits intomasterfrom
fix/lims-2103/ebic-shipment-message
Open

LIMS-2103: Display message for eBIC shipments if they try to access shipments#1039
gfrn wants to merge 4 commits intomasterfrom
fix/lims-2103/ebic-shipment-message

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Mar 2, 2026

JIRA ticket: LIMS-2103

Summary:

if eBIC users go to /shipments, they will find the page now displays text asking them to go to SCAUP, as this is the preferred way of defining those moving forward (for eBIC).

Changes:

  • Display message for eBIC shipments if they try to access shipments

To test:

@gfrn gfrn self-assigned this Mar 2, 2026
@gfrn gfrn added enhancement javascript Pull requests that update Javascript code labels Mar 2, 2026
@ndg63276
Copy link
Collaborator

ndg63276 commented Mar 2, 2026

This will hide the 'Add Shipment' for any proposal that ever uses eBIC, but some (eg nr27313) might use both MX and eBIC. So maybe leave the button and the warning?

@gfrn
Copy link
Collaborator Author

gfrn commented Mar 2, 2026

This will hide the 'Add Shipment' for any proposal that ever uses eBIC, but some (eg nr27313) might use both MX and eBIC. So maybe leave the button and the warning?

Good point, I'll remove the button.hide() call

@ndg63276
Copy link
Collaborator

ndg63276 commented Mar 2, 2026

Is it also worth checking that $redirects has an "em" value before showing the banner? That way if someone else uses this code they wouldn't see this code.

Co-authored-by: Mark W <24956497+ndg63276@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants