Skip to content

LIMS-2103: Display message for eBIC shipments if they try to access shipments #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gfrn wants to merge 4 commits into
base: master
Choose a base branch
from
Open

LIMS-2103: Display message for eBIC shipments if they try to access shipments #1039

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3907ef
Display message for eBIC shipments if they try to access shipments
gfrn Mar 2, 2026
3d2793a
Do not hide add shipments button
gfrn Mar 2, 2026
8370e23
Check if redirects has "em" before showing banner
gfrn Mar 2, 2026
14a742a
Update client/src/js/modules/shipment/views/shipments.js
gfrn Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion client/src/js/modules/shipment/views/shipments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ define(['marionette',

return Marionette.LayoutView.extend({
className: 'content',
template: '<div><h1>Shipments</h1><p class="help">This page shows a list of shipments associated with the currently selected proposal</p><p class="help">In order to register your samples you need to create a shipment. Shipments contain dewars, dewars contain containers, and containers individual samples. These can be created sequentially by viewing a particular shipment</p><div class="ra"><a class="button add" href="/shipments/add" data-testid="add-shipment-button"><i class="fa fa-plus"></i> Add Shipment</a></div><div class="wrapper"></div></div>',
template: '<div><h1>Shipments</h1><div id="ebic-banner" class="tw-hidden tw-my-4 tw-p-4 tw-bg-content-active tw-rounded tw-flex tw-justify-between"> <p class="tw-text-md"> eBIC is switching to SCAUP for shipments. <a id="ebic-link" href="">Click here to select a session and create a new shipment.</a></p></div><p class="help">This page shows a list of shipments associated with the currently selected proposal</p><p class="help">In order to register your samples you need to create a shipment. Shipments contain dewars, dewars contain containers, and containers individual samples. These can be created sequentially by viewing a particular shipment</p><div class="ra"><a class="button add" href="/shipments/add" data-testid="add-shipment-button"><i class="fa fa-plus"></i> Add Shipment</a></div><div class="wrapper"></div></div>',
regions: { 'wrap': '.wrapper' },
ui: {
add: 'a.add',
ebicBanner: 'div#ebic-banner',
ebicLink: 'a#ebic-link'
},

initialize: function(options) {
Expand All @@ -70,6 +72,10 @@ define(['marionette',
onRender: function() {
if (app.proposal && app.proposal.get('ACTIVE') != 1) this.ui.add.hide()

if (app.proposal.get("TYPES").includes("em") && "em" in app.options.get("redirects")) {
this.ui.ebicBanner.show();
this.ui.ebicLink.prop("href", `${app.options.get("redirects").em }/proposals/${app.proposal.get("PROPOSAL")}`);
}
this.wrap.show(this.table)
}
})
Expand Down
Loading