Skip to content

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Oct 21, 2025

Fixes

Requires

(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Note:

This PR requires updating when

Instructions to reviewer on how to test:

It should now be possible to

  1. Launch blueapi using the run_hyperion.sh script with the --blueapi flag, and connected to mock devices with the --dev flag
  2. Stop blueapi from the above script
  3. Run the load_centre_collect,robot_unload and move_to_udc_default_state plans with blueapi
  4. Fetch the plan schemas from the /plans endpoint
  5. Tests pass

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes
  • Acceptance criteria for parent issue are met

@DominicOram DominicOram added the hyperion Issues for Hyperion, the Bluesky UDC stack label Oct 30, 2025
@DominicOram
Copy link
Contributor

Ready to review, assuming linked PRs get merged

@DominicOram DominicOram self-requested a review November 24, 2025 10:13
@rtuck99 rtuck99 force-pushed the hyperion_on_blueapi branch from 552fdcf to 1c13914 Compare December 4, 2025 16:47
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (05d29b6) to head (f8aacea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   92.30%   92.32%   +0.01%     
==========================================
  Files         142      143       +1     
  Lines        8107     8126      +19     
==========================================
+ Hits         7483     7502      +19     
  Misses        624      624              
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 97.95% <100.00%> (+0.01%) ⬆️
other 98.09% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 force-pushed the hyperion_on_blueapi branch from 211fb63 to 575614e Compare January 5, 2026 16:12
@jacob720 jacob720 self-requested a review January 7, 2026 11:37
Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the only thing I didn't try was actually running the plans

"params": {
"visit": "cm12345-1"
},
"instrument_session": "cm12345-1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is visit needed as well as instrument session?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instrument_session is needed by blueapi. It is now exposed to callbacks in the run engine metadata. I think in future we will be able to get rid of the visit parameter, but we will need to update the callbacks, once everyone is on blueapi I think we can do this.

@rtuck99 rtuck99 enabled auto-merge (squash) January 8, 2026 11:51
@rtuck99 rtuck99 merged commit 83de359 into main Jan 8, 2026
13 checks passed
@rtuck99 rtuck99 deleted the hyperion_on_blueapi branch January 8, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hyperion Issues for Hyperion, the Bluesky UDC stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants