-
Notifications
You must be signed in to change notification settings - Fork 4
Ability to launch blueapi and run Hyperion plans #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ready to review, assuming linked PRs get merged |
552fdcf to
1c13914
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
+ Coverage 92.30% 92.32% +0.01%
==========================================
Files 142 143 +1
Lines 8107 8126 +19
==========================================
+ Hits 7483 7502 +19
Misses 624 624
🚀 New features to boost your workflow:
|
a02ffb7 to
0b3292e
Compare
211fb63 to
575614e
Compare
jacob720
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the only thing I didn't try was actually running the plans
| "params": { | ||
| "visit": "cm12345-1" | ||
| }, | ||
| "instrument_session": "cm12345-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is visit needed as well as instrument session?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instrument_session is needed by blueapi. It is now exposed to callbacks in the run engine metadata. I think in future we will be able to get rid of the visit parameter, but we will need to update the callbacks, once everyone is on blueapi I think we can do this.
Fixes
Requires
feat: Add option to connect as mock devices blueapi#1245feat: Add support for device manager beamline modules blueapi#1267(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Note:
This PR requires updating when
is merged
Instructions to reviewer on how to test:
It should now be possible to
run_hyperion.shscript with the--blueapiflag, and connected to mock devices with the--devflagload_centre_collect,robot_unloadandmove_to_udc_default_stateplans with blueapi/plansendpointChecks for reviewer