Change colorSeed default value in AppearanceSettings#1937
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa461f6a9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val theme: Theme = Theme.SYSTEM, | ||
| val dynamicTheme: Boolean = true, | ||
| val colorSeed: ULong = 4284960932u, | ||
| val colorSeed: ULong = 0x02EBD2u, |
There was a problem hiding this comment.
This literal drops the alpha channel: Compose packed colors are AARRGGBB, so 0x02EBD2u is fully transparent (AA=0x00). The app uses colorSeed directly as Color(colorSeed) in both theme generation (app/src/main/java/dev/dimension/flare/ui/theme/Theme.kt) and picker initialization (app/src/main/java/dev/dimension/flare/ui/screen/settings/ColorPickerDialog.kt), which means new installs now default to an alpha-0 seed and users can persist that transparent value unintentionally. If the intended default is visible #02EBD2, this should be 0xFF02EBD2u.
Useful? React with 👍 / 👎.
1 participant
No description provided.