Skip to content

Change colorSeed default value in AppearanceSettings #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tlaster merged 1 commit into from
Mar 27, 2026
Merged

Change colorSeed default value in AppearanceSettings #1937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/src/commonMain/kotlin/dev/dimension/flare/data/model/AppearanceSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import okio.BufferedSource
public data class AppearanceSettings(
val theme: Theme = Theme.SYSTEM,
val dynamicTheme: Boolean = true,
val colorSeed: ULong = 4284960932u,
val colorSeed: ULong = 0x02EBD2u,
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep default color seed opaque

This literal drops the alpha channel: Compose packed colors are AARRGGBB, so 0x02EBD2u is fully transparent (AA=0x00). The app uses colorSeed directly as Color(colorSeed) in both theme generation (app/src/main/java/dev/dimension/flare/ui/theme/Theme.kt) and picker initialization (app/src/main/java/dev/dimension/flare/ui/screen/settings/ColorPickerDialog.kt), which means new installs now default to an alpha-0 seed and users can persist that transparent value unintentionally. If the intended default is visible #02EBD2, this should be 0xFF02EBD2u.

Useful? React with 👍 / 👎.

val avatarShape: AvatarShape = AvatarShape.CIRCLE,
@Deprecated(
"Use postActionStyle instead",
Expand Down
Loading