Open
Conversation
added 2 commits
November 26, 2018 16:06
- Added note on impression tracking to README
jooj123
approved these changes
Dec 4, 2018
jooj123
reviewed
Dec 4, 2018
|
|
||
| To avoid recording duplicate impressions, consider ways to mitigate this: | ||
| - Adding a flag as a global variable to check if 'mount' events have already been fired | ||
| - Moving impression events outside of the experiment (into a wrapping component) |
Contributor
There was a problem hiding this comment.
might be useful to provide an example ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
I have
CHANGELOG.mdREADME.mdpackage.jsonare up to dateWhat's changed