Skip to content

Impression tracking note #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brettsnaidero wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Impression tracking note #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dee5590
Impression tracking note
Nov 26, 2018
a08f91b
Improve wording
Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,14 @@ An empty `Array` will move the current user into the control group.

Gets the props for the current variant from the groupVariants.

## Impression tracking

When the experiment props are received, the React component will remount, so any impression tracking events inside the component may be executed again (if they are in any lifecycle methods like `componentDidMount`).

To avoid recording duplicate impressions, consider ways to mitigate this:
- Adding a flag as a global variable to check if 'mount' events have already been fired
- Moving impression events outside of the experiment (into a wrapping component)
Copy link
Copy Markdown
Contributor

@jooj123 jooj123 Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be useful to provide an example ?


## Changes and history

See [CHANGELOG.md](./CHANGELOG.md).
Expand Down