Add Pressure Gradient design document#226
Conversation
vanroekel
left a comment
There was a problem hiding this comment.
Looks good, just a couple tiny questions from me.
|
Test compiled and posted here. |
components/omega/doc/design/PGrad.md
Outdated
| ## Verification and Testing | ||
|
|
||
| ### Test: Spatial convergence to exact solution | ||
| For a given analytical $v$, $h$, and $b$, the spatial convergence of the pressure gradient can be assessed by computing errors on progressively finer meshes. |
There was a problem hiding this comment.
I think maybe this should be fleshed out a bit more. What analytic test would we use?
There was a problem hiding this comment.
I revised this part slightly. I think we just need to specify arbitrary functions for the
16c3c49 to
c32bbb2
Compare
|
Latest version compiled here. |
mark-petersen
left a comment
There was a problem hiding this comment.
Thanks for your work on this. It looks great!
xylar
left a comment
There was a problem hiding this comment.
A few comments on the design doc, all of them small and hopefully easy to address.
xylar
left a comment
There was a problem hiding this comment.
I'm approving but I think we might still want to remove the baroclinic gyre test as not planned.
Co-authored-by: Mark Petersen <mark.petersen.la@gmail.com>
9edd946 to
b82a4ae
Compare
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/Omega#343 - [ ] (ocn) E3SM-Project/Omega#344 - [ ] (ocn) E3SM-Project/Omega#226 - [ ] (ocn) E3SM-Project/Omega#369 - [ ] (ocn) E3SM-Project/Omega#379
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/Omega#343 - [ ] (ocn) E3SM-Project/Omega#344 - [ ] (ocn) E3SM-Project/Omega#226 - [ ] (ocn) E3SM-Project/Omega#369 - [ ] (ocn) E3SM-Project/Omega#379
| $$ | ||
| to subtitute for $\partial r/\partial z$, and substituting $\Phi = gz + \phi_{TP} + \phi_{SAL}$ yields: | ||
| $$ | ||
| \alpha \nabla_z p &= \alpha\left( \nabla_r p + \rho g \nabla_r z\right) + \nabla_r \Phi - \frac{\partial r}{\partial z}\frac{\partial gz}{\partial r} \nabla_r z, \\ |
There was a problem hiding this comment.
Found a typo while reviewing #353
| \alpha \nabla_z p &= \alpha\left( \nabla_r p + \rho g \nabla_r z\right) + \nabla_r \Phi - \frac{\partial r}{\partial z}\frac{\partial gz}{\partial r} \nabla_r z, \\ | |
| \alpha \nabla_z p + \nabla_z \Phi &= \alpha\left( \nabla_r p + \rho g \nabla_r z\right) + \nabla_r \Phi - \frac{\partial r}{\partial z}\frac{\partial gz}{\partial r} \nabla_r z, \\ |
This PR adds the design document for the pressure gradient module for Omega-1. Compiled version here.
Checklist