Skip to content

Add Pressure Gradient design document#226

Merged
sbrus89 merged 9 commits intoE3SM-Project:developfrom
sbrus89:omega/pgrad-design
Mar 20, 2026
Merged

Add Pressure Gradient design document#226
sbrus89 merged 9 commits intoE3SM-Project:developfrom
sbrus89:omega/pgrad-design

Conversation

@sbrus89
Copy link
Copy Markdown
Collaborator

@sbrus89 sbrus89 commented Apr 22, 2025

This PR adds the design document for the pressure gradient module for Omega-1. Compiled version here.

Checklist

  • Documentation:
    • Design document has been generated and added to the docs
    • Documentation has been built locally and changes look as expected

Copy link
Copy Markdown
Collaborator

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple tiny questions from me.

Copy link
Copy Markdown

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions...

@mark-petersen
Copy link
Copy Markdown
Collaborator

Test compiled and posted here.

Copy link
Copy Markdown

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrus89, a few things to chat about at our Wednesday meeting (or sooner if you prefer). Nothing that should hold up moving forward on this.

## Verification and Testing

### Test: Spatial convergence to exact solution
For a given analytical $v$, $h$, and $b$, the spatial convergence of the pressure gradient can be assessed by computing errors on progressively finer meshes.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is $b$ in this case?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe this should be fleshed out a bit more. What analytic test would we use?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revised this part slightly. I think we just need to specify arbitrary functions for the $\alpha$, $h$, and $z$, then we can test the convergence of the discrete tendency compared to the analytical solution.

@sbrus89 sbrus89 force-pushed the omega/pgrad-design branch 3 times, most recently from 16c3c49 to c32bbb2 Compare September 18, 2025 17:49
@mark-petersen
Copy link
Copy Markdown
Collaborator

Latest version compiled here.

Copy link
Copy Markdown
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this. It looks great!

Copy link
Copy Markdown

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on the design doc, all of them small and hopefully easy to address.

@xylar
Copy link
Copy Markdown

xylar commented Feb 23, 2026

@sbrus89, I don't remember where things stand but this needs to be made consistent with the revisions to the v1 equations in #351.

@sbrus89 sbrus89 mentioned this pull request Feb 24, 2026
19 tasks
Copy link
Copy Markdown

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but I think we might still want to remove the baroclinic gyre test as not planned.

@sbrus89 sbrus89 force-pushed the omega/pgrad-design branch from 9edd946 to b82a4ae Compare March 20, 2026 21:46
@sbrus89 sbrus89 merged commit 0c350c7 into E3SM-Project:develop Mar 20, 2026
1 check passed
xylar added a commit to xylar/polaris that referenced this pull request Mar 27, 2026
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/Omega#343
- [ ]  (ocn) E3SM-Project/Omega#344
- [ ]  (ocn) E3SM-Project/Omega#226
- [ ]  (ocn) E3SM-Project/Omega#369
- [ ]  (ocn) E3SM-Project/Omega#379
xylar added a commit to xylar/polaris that referenced this pull request Mar 27, 2026
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/Omega#343
- [ ]  (ocn) E3SM-Project/Omega#344
- [ ]  (ocn) E3SM-Project/Omega#226
- [ ]  (ocn) E3SM-Project/Omega#369
- [ ]  (ocn) E3SM-Project/Omega#379
$$
to subtitute for $\partial r/\partial z$, and substituting $\Phi = gz + \phi_{TP} + \phi_{SAL}$ yields:
$$
\alpha \nabla_z p &= \alpha\left( \nabla_r p + \rho g \nabla_r z\right) + \nabla_r \Phi - \frac{\partial r}{\partial z}\frac{\partial gz}{\partial r} \nabla_r z, \\
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo while reviewing #353

Suggested change
\alpha \nabla_z p &= \alpha\left( \nabla_r p + \rho g \nabla_r z\right) + \nabla_r \Phi - \frac{\partial r}{\partial z}\frac{\partial gz}{\partial r} \nabla_r z, \\
\alpha \nabla_z p + \nabla_z \Phi &= \alpha\left( \nabla_r p + \rho g \nabla_r z\right) + \nabla_r \Phi - \frac{\partial r}{\partial z}\frac{\partial gz}{\partial r} \nabla_r z, \\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants