Revert PR #369 submodule bumps for CIME, EKAT, and SCORPIO#379
Conversation
mark-petersen
left a comment
There was a problem hiding this comment.
Passes cTests on Frontier CPU and GPU. I made sure the submodules were updated locally before the test. I also double checked that the submodules are the same as before the #369 merge:
$ git diff --stat 0c350c757c ede466f274
components/omega/doc/design/Tendencies.md | 2 +-
components/omega/src/ocn/Tendencies.cpp | 18 +++++++++---------
components/omega/src/ocn/Tendencies.h | 2 +-
components/omega/test/timeStepping/TimeStepperTest.cpp | 28 ++++++++++++++--------------
4 files changed, 25 insertions(+), 25 deletions(-)
TestingCTest unit tests:
CMake Error at /pscratch/sd/k/katsmith/Omega-PR/externals/cpptrace/cmake/Autoconfig.cmake:72 (message): Adding in the flag I am assuming that when these submodules are updated in PR #371 this will no longer be an issue, but I will test for that and report on that PR. |
|
I also tested on PM GPU and it works with the cmake flag Here are my full test instructions for PM GPU:
|
|
@katsmith133, in the future, it would be helpful if Omega branch names always start with |
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/Omega#343 - [ ] (ocn) E3SM-Project/Omega#344 - [ ] (ocn) E3SM-Project/Omega#226 - [ ] (ocn) E3SM-Project/Omega#369 - [ ] (ocn) E3SM-Project/Omega#379
This merge updates the e3sm_submodules/Omega submodule from [d0b3482](https://github.com/E3SM-Project/Omega/tree/d0b3482) to [74611d548d](https://github.com/E3SM-Project/Omega/tree/74611d548d). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/Omega#343 - [ ] (ocn) E3SM-Project/Omega#344 - [ ] (ocn) E3SM-Project/Omega#226 - [ ] (ocn) E3SM-Project/Omega#369 - [ ] (ocn) E3SM-Project/Omega#379
This PR reverts the most recent submodule pointer updates introduced in PR #369 for:
This is required before PR #371 to avoid conflict and to keep things clear.
Restored submodule SHAs:
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build