useMemo on sphere

[TheJeran]

Somehow the sphere component wasn't retriggering every frame before and I never noticed I shaderMaterial clone would cause massive issues. Not certain what was the previous changed to cause Sphere to update every frame. But wrapping it in useMemo solved the performance issue. Closes #566

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a performance bottleneck in the Sphere component by strategically applying the useMemo hook. The change specifically targets the shaderMaterial cloning process, which was previously causing excessive re-renders and performance degradation. By memoizing this operation, the component now renders more efficiently, enhancing overall application performance.

Highlights

• Performance Optimization: Addressed a significant performance issue in the Sphere component, which was caused by the shaderMaterial being cloned every frame, leading to unnecessary re-renders.
• useMemo Implementation: Wrapped the backMaterial cloning operation within the useMemo hook to prevent redundant computations and ensure the material is only re-created when its dependencies change, thereby improving rendering efficiency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/components/plots/AnalysisWG.tsx
  • Removed an unnecessary blank line within a useEffect hook.
• src/components/plots/Sphere.tsx
  • Applied useMemo to the shaderMaterial.clone() call for backMaterial to optimize rendering.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces useMemo to memoize the creation of a backMaterial in the Sphere component, which resolves a performance issue. My review focuses on improving the implementation of this memoization to follow best practices by ensuring the memoized object is fully configured within the useMemo hook.

[gemini-code-assist]

While memoizing backMaterial is the correct approach for performance, the property side is still being set on every render on line 146. It's better to create and fully configure the object within useMemo. You can do this concisely in one line, which would also allow you to remove the mutation on line 146.

Suggested change

	const backMaterial = useMemo(()=>shaderMaterial.clone(),[shaderMaterial])
	const backMaterial = useMemo(() => Object.assign(shaderMaterial.clone(), { side: THREE.BackSide }), [shaderMaterial]);