Skip to content

useMemo on sphere #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheJeran merged 2 commits into from
Feb 27, 2026
Merged

useMemo on sphere #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f86fdd6
useMemo on sphere
TheJeran Feb 27, 2026
977b013
include backside
TheJeran Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/plots/AnalysisWG.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ const AnalysisWG = ({ setTexture, }: { setTexture: React.Dispatch<React.SetState
setAnalysisMode(true);
setStatus(null);
}

Analyze()
},[executeCustom])

Expand Down
9 changes: 7 additions & 2 deletions src/components/plots/Sphere.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ export const Sphere = ({textures} : {textures: THREE.Data3DTexture[] | THREE.Dat

const {lonBounds, latBounds} = useCoordBounds()


const geometry = useMemo(() => new THREE.IcosahedronGeometry(1, sphereResolution), [sphereResolution]);
const shaderMaterial = useMemo(()=>{
const shader = new THREE.ShaderMaterial({
Expand Down Expand Up @@ -140,8 +141,12 @@ export const Sphere = ({textures} : {textures: THREE.Data3DTexture[] | THREE.Dat
return shader
},[isFlat, textures, borderTexture])

const backMaterial = shaderMaterial.clone()
backMaterial.side = THREE.BackSide;
const backMaterial = useMemo(()=>{
const mat = shaderMaterial.clone()
mat.side = THREE.BackSide;
return mat;
},[shaderMaterial])

useEffect(()=>{
if (shaderMaterial){
const uniforms = shaderMaterial.uniforms;
Expand Down
Loading