Recommended requirements#219
Conversation
nettle
requested review from
Szelethus and
furtib
and removed request for
furtib
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
The patch is correct. I posted some comments in the associated issue first.
| module add git | ||
| module add bazel/6 | ||
| module add clang/16 | ||
| module add bazel/7 |
There was a problem hiding this comment.
There is only Bazel 7.3.1 in "my" RHEL8 environment, which does not work :(
I guess I need to remove all of these "module add" things as not actual.
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Reading the specific wording of the summary ("recommended" versions), I agree with sentiment, but I'm wondering we should use more permissive language in the README, like "bazel >=7.7 but <9". Or, we could copy your definition of "recommended" from #164 (comment).
| - Python 3.8 or newer (we use 3.11) | ||
| - CodeChecker 6.26 or newer (we use 6.26.0) | ||
| - Git 2 or newer | ||
| - Bazel 7.7 |
There was a problem hiding this comment.
We added bazel 8 support recently. Among other things, we run regular bazel 8 CI jobs for both Ubuntu and Rhel. I suggest we add 8.5.0 or 8.6.0 as well, that is a rather hard requirement from other parties.
There was a problem hiding this comment.
Well, we should make a decision about Recommended requirements.
Is it 7.7 or 8.5 or 8.6?
There was a problem hiding this comment.
I suggest that it should be 7.7 and 8.6. My understanding is that within a major Bazel release, upgrading to a newer minor release is straightforward. But, with regards to major versions, if "recommended versions" are, in part, according to your comment, those that
- We set them as default for Development Environment
- All tests must always pass in the environment with Recommended requirements
- We recommend them to the users as absolutely reliable
- We immediately fix all issues if they are reported in Recommended requirements
beside the first point, both bazel 7 and 8 (and the respective latest minor versions) qualify pretty strongly for that, as there are other teams using these rules that use bazel 8 exclusively.
2 participants
Why:
We need to agree on recommended requirements
to use for development and run all tests
What:
Addresses: #164