Skip to content

Recommended requirements #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nettle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Recommended requirements #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bazelignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
test/unit/external_repository
.ci/micromamba
8 changes: 4 additions & 4 deletions .ci/micromamba/dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ dependencies:
- pylint
- pycodestyle
- buildifier
- clang
- clang-tools
- bazel=6
- clang=21
- clang-tools=21
- bazel=7.7.1
- pip:
- codechecker==6.25
- codechecker==6.27.3
4 changes: 2 additions & 2 deletions .ci/mise/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ experimental = true

[tools]
# Environment tools:
"bazel" = "6.5"
"bazel" = "7.7.1"
"python" = "3.11"
"pipx" = "latest"
"pipx:codechecker" = "6.26"
"pipx:codechecker" = "6.27.3"

# Clang tools:
"conda:clang" = "latest"
Expand Down
1 change: 1 addition & 0 deletions BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ buildifier_test(
name = "buildifier_native",
diff_command = "diff -u",
exclude_patterns = [
"./.ci/*",
Copy link
Copy Markdown
Contributor

@Szelethus Szelethus Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.

Copy link
Copy Markdown
Collaborator Author

@nettle nettle Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, still does not work :(

Copy link
Copy Markdown
Collaborator Author

@nettle nettle Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now addressed in #220

"./.git/*",
],
lint_mode = "warn",
Expand Down
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,20 @@ Prerequisites

We need the following tools:

- Git 2 or newer (we use 2.36)
- Bazel 6, 7 or 8 (we recommend version 8.5.0)
- Clang 16 or newer (we use 16), we use clang-tidy
- Python 3.8 or newer (we use 3.11)
- CodeChecker 6.26 or newer (we use 6.26.0)
- Git 2 or newer
- Bazel 7.7
Copy link
Copy Markdown
Contributor

@Szelethus Szelethus Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added bazel 8 support recently. Among other things, we run regular bazel 8 CI jobs for both Ubuntu and Rhel. I suggest we add 8.5.0 or 8.6.0 as well, that is a rather hard requirement from other parties.

Copy link
Copy Markdown
Collaborator Author

@nettle nettle May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we should make a decision about Recommended requirements.
Is it 7.7 or 8.5 or 8.6?

Copy link
Copy Markdown
Contributor

@Szelethus Szelethus May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that it should be 7.7 and 8.6. My understanding is that within a major Bazel release, upgrading to a newer minor release is straightforward. But, with regards to major versions, if "recommended versions" are, in part, according to your comment, those that

  1. We set them as default for Development Environment
  2. All tests must always pass in the environment with Recommended requirements
  3. We recommend them to the users as absolutely reliable
  4. We immediately fix all issues if they are reported in Recommended requirements

beside the first point, both bazel 7 and 8 (and the respective latest minor versions) qualify pretty strongly for that, as there are other teams using these rules that use bazel 8 exclusively.

- Clang and clang-tidy 21
- Python 3.11 or newer
- CodeChecker 6.27.3

If, by chance, Environment Modules (https://modules.sourceforge.net/)
are available in your system, you can just add the following modules:

module add git
module add bazel/6
module add clang/16
module add bazel/7
Copy link
Copy Markdown
Collaborator Author

@nettle nettle Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only Bazel 7.3.1 in "my" RHEL8 environment, which does not work :(
I guess I need to remove all of these "module add" things as not actual.

module add clang/21
module add python/3.11
module add codechecker/6.26
module add codechecker/6.27.3


Getting Started
Expand Down
3 changes: 1 addition & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
pytest
pylint
codechecker >= 6.26

codechecker >= 6.27.3
Loading