-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Create View-the-Top-Categories-report.md #81051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new documentation file for the Top Categories report feature in New Expensify. The document provides clear, user-focused guidance for Workspace Admins, Approvers, and Auditors. The structure is well-organized with proper headings, FAQ section, and good use of context-setting introductions. However, there are several areas where the document can be strengthened for AI readiness, style compliance, and consistency with Expensify documentation standards. Scores Summary
Key FindingsPositive Aspects:
Critical Issues:
Pattern Issues:
RecommendationsPriority Actions (Must Address Before Merge):
Style and Consistency Improvements:
AI Readiness Enhancements:
Content Improvements:
Files Reviewed
Note: This assessment focuses on documentation quality, AI readability, and style compliance per HelpDot standards. Technical accuracy of feature descriptions should be verified by the product team. |
docs/articles/new-expensify/insights/View-the-Top-Categories-report.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/insights/View-the-Top-Categories-report.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/insights/View-the-Top-Categories-report.md
Outdated
Show resolved
Hide resolved
|
A preview of your ExpensifyHelp changes have been deployed to https://37a1a10b.helpdot.pages.dev ⚡️ Updated articles: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53196d37d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ## Can other people see my Top Categories report? | ||
|
|
||
| Only Workspace Admins, Approvers, and Auditors can access the Top Categories report for a workspace. Regular members do not have access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct Top Categories access roles
SearchUIUtils shows the Top Categories suggested search is available to any member of a paid policy with categories enabled (isEligibleForTopCategoriesSuggestion = isPaidPolicy && policy.areCategoriesEnabled === true, no role check). This means regular members can see it, so stating that only Admins/Approvers/Auditors have access is inaccurate and will mislead users who do see it. Consider aligning the doc with the actual eligibility (or update the product gating if the restriction is intended).
Useful? React with 👍 / 👎.
|
|
||
| ## How to interpret the Top Categories report | ||
|
|
||
| Each row represents a single expense category, sorted in descending order by total spend. Columns include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid claiming Top Categories is sorted by spend
The Top Categories suggested search is built with createTopSearchMenuItem, which sets sortBy to GROUP_CATEGORY and sortOrder to ASC when grouping by category (SearchUIUtils.ts:470-482). That means the default result ordering is alphabetical, not by total spend, so statements that it’s sorted in descending spend (or shows the highest spend categories) are inaccurate.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha agreed.
trjExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty great! ❤️
|
|
||
| ## Who can use the Top Categories report | ||
|
|
||
| The Top Categories report is available to Workspace Admins, Approvers, and Auditors on both web and mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top Categories is available to all workspace members. Members would just see their own categories.
|
|
||
| ## How to interpret the Top Categories report | ||
|
|
||
| Each row represents a single expense category, sorted in descending order by total spend. Columns include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha agreed.
|
|
||
| ## How to interpret the Top Categories report | ||
|
|
||
| Each row represents a single expense category, sorted in descending order by total spend. Columns include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've got the bar chart view on staging, which means once that gets to prod, we'll ship this PR to make the Top categories view a bar chart by default: #81074
Resource tracking issue: https://github.com/Expensify/Expensify/issues/588072
Design request: https://github.com/Expensify/Expensify/issues/594912
I requested a screenshot for this for design, I can add it later so no need to hold the doc on it.
@trjExpensify this is ready for you!