-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: Screen Reader: Split Expense: Elements of each row are grouped, cannot focus/activate separately #81088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…cannot focus/activate separately
…Reader-Split-Expense-Elements-of-each-row-are-grouped-cannot-focus/activate-separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f14aa09f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Explanation of Change
Screen reader users (VoiceOver/TalkBack) could not independently focus on the amount/percentage TextInput fields in Split Expense rows because the parent PressableWithFeedback had accessible={true} by default, which groups
all children as a single accessibility element.
This fix:
Fixed Issues
$ #77465
PROPOSAL: #77465 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20260131_113710_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20260131_113121_Chrome.mp4
iOS: Native
Screen.Recording.2026-01-31.at.10.39.15.in.the.morning.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-31.at.11.01.49.in.the.morning.mov