-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: Screen Reader: Split Expense: Elements of each row are grouped, cannot focus/activate separately #81088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TaduJR
wants to merge
7
commits into
Expensify:main
Choose a base branch
from
TaduJR:fix-Screen-Reader-Split-Expense-Elements-of-each-row-are-grouped-cannot-focus/activate-separately
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−7
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6f14aa0
fix: Screen Reader: Split Expense: Elements of each row are grouped, …
TaduJR b47f76d
Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…
TaduJR e89a037
fix: add missing sentryLabel prop to BaseListItem PressableWithFeedback
TaduJR 0a7e189
fix: make split expense row elements accessible and consistent across…
TaduJR bc80b30
fix: make split expense text content keyboard-focusable on web
TaduJR 4c8dc04
fix: use CONST.ROLE.SUMMARY for split expense text content role
TaduJR 9504a4b
fix: hide child elements from accessibility tree to fix grouping on A…
TaduJR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.