[refactor] Clean Arch + Typescript#349
Merged
adrianq merged 37 commits intodevelopmentfrom Apr 21, 2026
Merged
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Move the OrganisationUnit type from models/db.types to a proper domain entity (as a Struct class with a getFullOrgUnitName method). Implement OrganisationUnitD2Repository using d2-api and expose it through the composition root as a use case, replacing the ad-hoc DbD2.getOrganisationUnitsFromIds and Campaign.getOrganisationUnitsWithName.
Preparatory step for TypeScript migration. No runtime changes.
Add types to all functions and local types (AreaType, ItemConfig, ConstructorOptions, etc). Export ModelDataDimensionItem and D2DataDimensionItem from campaign-d2-visualizations. Fix latent null-access bug on antigen.name in chartConstructor. Replace non-null assertions with assert().
Clearer name: the flag indicates whether target population data has been saved to the server, not whether values are "up to date".
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
This is the continuation of #345
📝 Implementation
models/campaign.ts: this file should eventually bedomain/entities/Campaign.tswithout any references todb: DbD2.d2: D2(provided by deprecated "d2" package, used with manual typing) byapi: D2Api(d2-api, fully typed). Recent code already uses d2-api.