Remove non-finite fill values for pf.ice_ext() calculation#235
Merged
JanStreffing merged 3 commits intomainfrom Mar 26, 2026
Merged
Remove non-finite fill values for pf.ice_ext() calculation#235JanStreffing merged 3 commits intomainfrom
JanStreffing merged 3 commits intomainfrom
Conversation
With the fill value change from 0 to nan in fesom2.7 the pf.ice_ext() did return incorrect values.
Replace finite mask calculation to handle NaN values and update data accordingly.
The previous fix still had the critical bug where .where() operations converted NaN land cells to ice (value=1), causing 10x overestimation. This commit replaces the .where() logic with xr.where() that creates a proper binary field while explicitly preserving NaN values for land. Changes: - xarray path: Use xr.where() to create binary field, then preserve NaN - numpy path: Create binary field with np.where(), then restore NaN values - Both paths now correctly exclude land cells from ice extent calculation Tested with AWI-ESM3 data - values now show realistic ~20 million km² instead of inflated ~200 million km².
Contributor
|
Why closed? |
Contributor
|
Before (and after putting proper NaNs into fesom output): (ignore the apparent unit change. that was a separate oversight. nothing changed in the computation other than what you see in the PR) |
Contributor
|
Not sure why the tests are failing. @pgierz ? |
Contributor
|
Ready for review from my side. |
koldunovn
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the fill value change from 0 to nan in fesom2.7 the pf.ice_ext() did return incorrect values.