Skip to content

Remove non-finite fill values for pf.ice_ext() calculation #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanStreffing merged 3 commits into from
Mar 26, 2026
Merged

Remove non-finite fill values for pf.ice_ext() calculation #235

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dcbcf3
Remove non-finite fill values for pf.ice_ext() calculation
FinnHeu Mar 17, 2026
fa25905
Fix finite mask calculation and handle NaN values
FinnHeu Mar 25, 2026
60d9e9e
Fix ice_ext to properly preserve NaN land cells
JanStreffing Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions pyfesom2/diagnostics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,21 +73,26 @@ def ice_ext(data, mesh, hemisphere="N", threshhold=0.15, attrs={}):
hemis_mask = mesh.y2 < 0

if isinstance(data, xr.DataArray):
data = data.where(data < threshhold, 1)
data = data.where(data > threshhold)
# Create binary ice extent field: 1 where ice >= threshold, 0 where < threshold, NaN stays NaN
ice_binary = xr.where(data >= threshhold, 1, 0)
ice_binary = ice_binary.where(~np.isnan(data)) # Preserve NaN values (land)

ext = (data[:, hemis_mask] * mesh.lump2[hemis_mask]).sum(axis=1)
finite_mask = ~np.isnan(ice_binary.squeeze().values)

ext = (ice_binary[:, hemis_mask & finite_mask] * mesh.lump2[hemis_mask & finite_mask]).sum(axis=1)
da = xr.DataArray(
ext, dims=["time"], coords={"time": data.time}, name=varname, attrs=attrs
)
return da

else:
logger.debug(data)
i, j = np.where(data < 0.15)
data[:] = 1
data[i, j] = 0
ext = (data[:, hemis_mask] * mesh.lump2[hemis_mask]).sum(axis=1)
# Create binary ice extent field: 1 where ice >= threshold, 0 where < threshold, NaN stays NaN
ice_binary = np.where(data >= threshhold, 1, 0).astype(float)
ice_binary[np.isnan(data)] = np.nan # Preserve NaN values (land)

finite_mask = ~np.isnan(ice_binary.squeeze())
ext = (ice_binary[:, hemis_mask & finite_mask] * mesh.lump2[hemis_mask & finite_mask]).sum(axis=1)
return ext


Expand Down
Loading