Fix application null exception & Remove unused MainWindowOpacity property

[Jack251970]

When application is shutdowning, Application.Current will be null.

[gitstream-cm]

🥷 Code experts: onesounds

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher/MainWindow.xaml

Activity based on git-commit:

	Jack251970	onesounds
MAR	28 additions & 20 deletions
FEB	1 additions & 1 deletions
JAN
DEC
NOV	1 additions & 1 deletions
OCT

Knowledge based on git-blame:
onesounds: 87%
Jack251970: 4%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	Jack251970	onesounds
MAR	821 additions & 829 deletions	327 additions & 141 deletions
FEB	1 additions & 1 deletions	8 additions & 4 deletions
JAN
DEC	5 additions & 10 deletions
NOV
OCT

Knowledge based on git-blame:
Jack251970: 59%
onesounds: 19%

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

	Jack251970	onesounds
MAR	450 additions & 416 deletions	293 additions & 201 deletions
FEB	63 additions & 21 deletions	23 additions & 25 deletions
JAN	17 additions & 21 deletions
DEC	59 additions & 63 deletions
NOV	39 additions & 15 deletions
OCT

Knowledge based on git-blame:
Jack251970: 25%
onesounds: 11%

To learn more about /:\ gitStream - Visit our Docs

[Copilot]

Pull Request Overview

This PR fixes a null reference exception during shutdown by adding null checks for Application.Current and removes the unused MainWindowOpacity property. It also refines the clock panel’s animation logic and cleans up minor stylistic issues in event handlers.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
Flow.Launcher/ViewModel/MainViewModel.cs	Removed unused MainWindowOpacity property and added null checks on Application.Current.
Flow.Launcher/MainWindow.xaml.cs	Improved UI event handling and adjusted conditions in the UpdateClockPanelVisibility method.

Files not reviewed (1)

• Flow.Launcher/MainWindow.xaml: Language not supported

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request removes the dynamic opacity binding from the main window and revises UI control flow logic. In MainWindow.xaml, the Opacity binding is deleted, while MainWindow.xaml.cs sees updates in event handling and clock panel animation logic with added null-checks and simplified conditions. In MainViewModel.cs, the MainWindowOpacity property is removed and replaced with a boolean MainWindowVisibilityStatus, with corresponding updates in the show/hide methods. Several formatting improvements round out the changes.

Changes

File(s)	Change Summary
Flow.Launcher/MainWindow.xaml	Removed the Opacity property binding from the Window element, eliminating the dynamic adjustment of the main window's opacity at runtime.
Flow.Launcher/MainWindow.xaml.cs	Renamed event handler parameter; added null-checks in UpdateClockPanelVisibility; refined fade-in and fade-out animation logic for ClockPanel without using Dispatcher.Invoke.
Flow.Launcher/ViewModel/MainViewModel.cs	Removed the MainWindowOpacity property and introduced a new boolean property, MainWindowVisibilityStatus, with corresponding updates to the Show and Hide methods.

Possibly related PRs

• Fix first-time window flicker & clock panel flicker issue #3391: Related to the removal of the Opacity property binding for the main window, which impacts opacity management in the UI.
• Fix issue that mainVM fails to work #3296: Involves changes to the MainViewModel, particularly the removal of the MainWindowOpacity property.
• Fix Clock/Search Icon show logic #3388: Focuses on refining ClockPanel visibility and animation behavior in MainWindow.xaml.cs, similar to the modifications in this PR.

Suggested labels

bug, enhancement

Suggested reviewers

• jjw24

Poem

I'm a rabbit hopping through the code,
Leaping over bugs on my joyful road.
With opacity gone, my steps feel light,
Visibility shines, oh what a sight!
My little paws tap a rhythmic beat—
Hop on, let’s make our code complete!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 494e947 and c64e16d.

📒 Files selected for processing (1)

• Flow.Launcher/MainWindow.xaml.cs (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Flow.Launcher/MainWindow.xaml.cs

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	24
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.