Remove favorites flag system, consolidate to collection-based grouping by Copilot · Pull Request #2 · FreePeak/opencall

Copilot · 2026-01-15T17:50:06Z

Summary: Replace Favorites with Collection-based Grouping ✅

Problem Solved: The codebase had two conflicting systems:

Simple boolean flag-based "favorites" (flat list, no hierarchy)
Hierarchical "collections" system (proper grouping support)

Users could not organize or group favorite requests into folders.

Solution Implemented: Removed the favorites flag system entirely. Now users organize requests exclusively through the Collections system, which supports hierarchical grouping with folders.

Changes Made

Backend Changes

✅ Removed isUserFavorite and favoritedTime fields from IUserRequestSidebarState type
✅ Removed FAVORITES_COLLECTION and favorites-related constants
✅ Removed ADD_TO_FAVORITES and REMOVE_FROM_FAVORITES commands
✅ Updated ExtensionStateManger to remove favorites state management
✅ Removed unused updateExtensionContext method (was only used for favorites)
✅ Updated SidebarWebViewPanel to not send/handle favorites data
✅ Updated MainWebViewPanel to remove favorites initialization and toggles
✅ Removed unused filterDuplicatesFromObject utility functions

Frontend Changes

✅ Removed "Favorites" from sidebar menu options (now: Collections, History)
✅ Updated sidebarSlice to remove favorites state and handlers:
- Removed userFavorites state
- Removed handleUserFavoritesCollection
- Removed handleUserFavoriteIcon
- Removed addCollectionToFavorites
- Removed removeFromFavoriteCollection
- Removed resetFavoriteIconState
✅ Removed favorites constants from SIDEBAR
✅ Updated SidebarMenuOption to remove favorites toggle logic
✅ Updated SidebarMenu to not process favorites messages
✅ Removed heart icons (favorite/unfavorite) from SidebarCollection
✅ Cleaned up SidebarEmptyCollectionMenu to not show favorites empty state
✅ Removed favorite CSS styling from MoreInformation component

Build & Quality Checks

✅ TypeScript compilation: 0 errors
✅ Webpack build: Success (with standard warnings)
✅ Code review: All comments addressed
✅ Security scan: 0 vulnerabilities found (CodeQL)

How to Validate

Build the extension:

npm install --legacy-peer-deps
npm run build

Install in VS Code:

make package
code --install-extension opencall.vsix

Test the changes:
- Open VS Code and activate the OpenCall extension
- Open the sidebar (should show "Collections" and "History" tabs only)
- Verify no "Favorites" tab exists
- Test that Collections tab works and can organize requests hierarchically
- Test that History tab shows recent requests
- Verify no heart icons appear in the History view
Expected behavior:
- Sidebar has 2 tabs: "Collections" and "History" (no "Favorites")
- Collections support hierarchical organization with folders
- History shows chronological list of requests
- No favorite toggle functionality anywhere in the UI

Impact

Before:

Users had a "Favorites" tab with a flat list of favorited requests (no folders)
Favorites used boolean flags on history items
Collections existed but were separate from favorites

After:

Users have a "Collections" tab with full hierarchical organization
Collections support nested folders for proper grouping
Single unified system for organizing requests
Cleaner codebase with less duplication

Security Summary

✅ No vulnerabilities found - CodeQL JavaScript analysis completed with 0 alerts

Original prompt

Collection management is broken replace favorite by collection but it can group requests

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: linhdmn <13645510+linhdmn@users.noreply.github.com>

Copilot

Pull request overview

This PR removes the redundant favorites flag-based system and consolidates request organization into the collection-based hierarchical grouping system. The change eliminates duplicate state management by removing the boolean isUserFavorite flag system that provided a flat list, while keeping the more powerful collection-based folder support.

Changes:

Removed favorites state management and UI (tabs, icons, handlers) from frontend and backend
Removed isUserFavorite and favoritedTime fields from request state interfaces
Deleted filterDuplicatesFromObject utility and associated favorites constants
Simplified sidebar menu to show only Collections and History tabs

Reviewed changes

Copilot reviewed 18 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
webview/store/slices/type.d.ts	Removed favorites-related properties from interfaces (`isUserFavorite`, `favoritedTime`, `userFavorites`, and handler methods)
webview/store/slices/sidebarSlice.ts	Removed favorites state slice and all favorites-related handler functions
webview/features/Sidebar/Menu/SidebarMenuOption.tsx	Simplified handlers to only work with history collection, removed favorites case from switch statement
webview/features/Sidebar/Menu/SidebarMenu.tsx	Removed favorites message handling and state updates
webview/features/Sidebar/Menu/SidebarEmptyCollectionMenu.tsx	Removed favorites empty state import and simplified conditional rendering
webview/features/Sidebar/Collection/SidebarCollection.tsx	Removed heart icon imports and favorites toggle functionality from collection items
webview/constants/sidebar.ts	Removed favorites-related constants (`FAVORITES`, `ADD_TO_FAVORITES`, `REMOVE_FROM_FAVORITES`, `USER_FAVORITES_COLLECTION`, `FAVORITES_COLLECTION`)
webview/constants/options.ts	Removed "Favorites" from sidebar menu options array
webview/components/MoreInformation.tsx	Removed favorite heart icon styling
src/utils/type.d.ts	Removed `isUserFavorite` and `favoritedTime` from request state interface
src/utils/index.ts	Removed export of `filterDuplicatesFromObject` utility
src/utils/filterDuplicatesFromObject.ts	Deleted entire utility file used for favorites deduplication
src/extension/utils/type.d.ts	Removed `isUserFavorite` and `favoritedTime` from request state interface
src/extension/utils/index.ts	Removed export of `filterDuplicatesFromObject` utility
src/extension/utils/filterDuplicatesFromObject.ts	Deleted entire utility file used for favorites deduplication
src/extension/extension.ts	Removed favorites collection initialization on extension activation
src/extension/constants/command.ts	Removed favorites command constants
src/extension/constants/collection.ts	Removed favorites collection constant and filterable keys
src/extension/SidebarWebViewPanel.ts	Removed favorites data retrieval, message handling for add/remove favorites operations, and favorites parameter from update method
src/extension/MainWebViewPanel.ts	Removed `isUserFavorite` and `favoritedTime` initialization when creating request history items
src/extension/ExtensionStateManger.ts	Removed favorites state update logic and `filterDuplicatesFromObject` import from `updateExtensionContext` method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T02:43:21Z

  async updateExtensionContext(state: string, id: string, status?: string) {
-    const currentTime = new Date().getTime();
    const globalHistoryState: IUserRequestSidebarState[] | undefined =
      this.context.globalState.get(state);
-    const globalFavoritesState: IUserRequestSidebarState[] | undefined =
-      this.context.globalState.get(COLLECTION.FAVORITES_COLLECTION);

-    if (!globalHistoryState || !globalFavoritesState) return;
-
-    globalHistoryState.map(
-      (history) =>
-        history.id === id &&
-        ((history.isUserFavorite = !history.isUserFavorite),
-        (history.favoritedTime = currentTime)),
-    );
+    if (!globalHistoryState) return;

+    // No favorites update needed anymore
    await this.context.globalState.update(state, [...globalHistoryState]);
-
-    if (status) {
-      const duplicateFilteredUserFavoriteCollection =
-        filterDuplicatesFromObject(
-          globalHistoryState,
-          globalFavoritesState,
-          id,
-        );
-
-      await this.context.globalState.update(COLLECTION.FAVORITES_COLLECTION, [
-        ...duplicateFilteredUserFavoriteCollection,
-      ]);
-    }
  }


The updateExtensionContext method now only retrieves the state and immediately updates it with the same data without any modifications. The id and status parameters are no longer used. Consider removing this method entirely or clarifying its purpose, as it currently performs no meaningful operation.

Removed the unused method in commit 13b1181. It was only performing a no-op after favorites were removed.

linhdmn · 2026-01-16T09:19:47Z

@copilot how to validate your changes work?

Co-authored-by: linhdmn <13645510+linhdmn@users.noreply.github.com>

Copilot · 2026-01-16T09:22:31Z

@copilot how to validate your changes work?

To validate the changes:

Build: npm install --legacy-peer-deps && npm run build
Package: make package (creates opencall.vsix)
Install: code --install-extension opencall.vsix
Test:
- Open VS Code sidebar - verify only "Collections" and "History" tabs (no "Favorites")
- Check History view - no heart icons for favoriting
- Verify Collections tab supports hierarchical organization

Expected UI changes:

Sidebar menu reduced from 3 tabs (Collections/History/Favorites) to 2 tabs (Collections/History)
No favorite toggle icons in History view
Collections remain fully functional with folder support for grouping requests

Initial plan

15a5a2b

Copilot AI assigned Copilot and linhdmn Jan 15, 2026

Copilot started work on behalf of linhdmn January 15, 2026 17:50 View session

Copilot AI and others added 4 commits January 15, 2026 17:59

Remove favorites flag system from codebase

3a6b6dc

Co-authored-by: linhdmn <13645510+linhdmn@users.noreply.github.com>

Fix compilation errors and build successfully

bcde912

Co-authored-by: linhdmn <13645510+linhdmn@users.noreply.github.com>

Clean up favorites references in UI components

54b9e8e

Co-authored-by: linhdmn <13645510+linhdmn@users.noreply.github.com>

Remove unused filterDuplicatesFromObject utility functions

6556691

Co-authored-by: linhdmn <13645510+linhdmn@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix collection management by replacing favorite with collection~~ Remove favorites flag system, consolidate to collection-based grouping Jan 15, 2026

Copilot AI requested a review from linhdmn January 15, 2026 18:10

Copilot finished work on behalf of linhdmn January 15, 2026 18:10

linhdmn marked this pull request as ready for review January 16, 2026 02:39

linhdmn requested a review from Copilot January 16, 2026 02:39

Copilot started reviewing on behalf of linhdmn January 16, 2026 02:40 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot started work on behalf of linhdmn January 16, 2026 09:20 View session

Remove unused updateExtensionContext method

13b1181

Co-authored-by: linhdmn <13645510+linhdmn@users.noreply.github.com>

Copilot finished work on behalf of linhdmn January 16, 2026 09:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove favorites flag system, consolidate to collection-based grouping#2

Remove favorites flag system, consolidate to collection-based grouping#2
Copilot wants to merge 6 commits intomainfrom
copilot/replace-favorite-with-collection

Copilot AI commented Jan 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

linhdmn commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary: Replace Favorites with Collection-based Grouping ✅

Changes Made

Backend Changes

Frontend Changes

Build & Quality Checks

How to Validate

Impact

Security Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

linhdmn commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 15, 2026 •

edited

Loading