-
Notifications
You must be signed in to change notification settings - Fork 10
Add ISSM ice sheet model GridComp to Landice #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
agstub
wants to merge
91
commits into
develop
Choose a base branch
from
feature/agstub/issm-gridcomp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged. |
Contributor
Author
v11: Build ISSM based on detection of ISSM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft PR adds a new gridcomp that runs ISSM, NASA's Ice-sheet and Sea-level System Model. The ISSM gridcomp is a child of the Landice gridcomp. This Draft PR was spurred by discussions in this issue, which provides an overview and outlines some other changes and development issues.
Overview of the new ISSM gridcomp:
Imports: ICESMB (ice surface mass balance) from landice (described below)
Exports: ICEEL (ice surface elevation)
Specifically, ICESMB is passed as an input to ISSM that influences the ice-surface elevation, which is exported as ICEEL.
The ISSM gridcomp does two main things:
Currently, output of ICEEL and ICESMB via HISTORY is restricted to the landice tilespace or the attached grid. Note: We are discussing ways to output fields defined on the mesh by creating a new tilespace where each tile corresponds to an element (triangle) of the mesh.
Major changes to landice:
Potential issues to fix:
Discussions with @weiyuan-jiang and @mathomp4 suggest we may need to modify CMakeLists.txt for landice (and issm?) to "stub" the build in case the ISSM module is not present.
Related Issues and PRs:
Will update these as progress is made:
A word of caution:
This is my first big draft PR so please don't hesitate to let me know if I did something wrong. I tried to provide ample comments in the new ISSM gridcomp to highlight each step.