Add ISSM fields to HISTORY and initialization arguments #161
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged. |
Contributor
|
The variables in the same collection should have the same tile or gridded space. We have discussion that ISSM should have output in mesh-like space. So ICEEL should not be in this collection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this Draft PR is to add two new variables from ISSM (Ice-Sheet and Sea-Level System Model) to HISTORY. The variables are ICESMB (ice surface mass balance: exported from LandIce GridComp) and ICEEL (ice surface elevation: exported from ISSM GridComp). Ongoing development by @weiyuan-jiang will explore outputting these variables with HISTORY on a tile space that corresponds to the (unstructured, triangular) elements of ISSM's mesh (rather than the current options of gridded or landice tile outputs). We currently also save handwritten mesh output (via ESMF_FieldWrite) with the new ISSM_SAVEMESH flag defined in GEOSldas_LDAS.rc.
The PR also adds configuration parameters to GEOSldas_LDAS.rc that are required by ISSM for initialization: ISSM_EXPDIR and ISSM_EXPNAME. ISSM_EXPDIR points to the directory containing the ISSM input file, which will be replaced by a restart directory in the future. ISSM_EXPNAME is the name of the binary input file (ISSM_EXPNAME.bin) and PETSc options file (ISSM_EXPNAME.toolkits).
Related issues and PRs