[MISC] Minor updates for viewer plugins#2728
[MISC] Minor updates for viewer plugins#2728Milotrince wants to merge 5 commits intoGenesis-Embodied-AI:mainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20343932dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| self._debug_interact_nodes.append(self.scene.draw_debug_mesh(self._plane_mesh, T=plane_T)) | ||
| else: | ||
| self.scene.update_debug_objects(self._debug_interact_nodes, (sphere_T, line_T, plane_T)) |
There was a problem hiding this comment.
This branch initializes only two interaction debug nodes (sphere and plane), but later updates always pass three transforms (sphere_T, line_T, plane_T) to update_debug_objects. Since that API zips objects with poses, the third pose is ignored and the plane gets line_T, so held-object visuals are wrong (line never appears and plane transform is corrupted) during drag interactions.
Useful? React with 👍 / 👎.
1 participant
Description
Related Issue
Motivation and Context
minor fixes
How Has This Been / Can This Be Tested?
n_envshas been added as parameter to plugin testsScreenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.