Add h5diff message about file object difference #6103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
the
Component - Tools
mattjala
requested review from
byrnHDF,
derobins,
fortnern,
jhendersonHDF,
lrknox and
qkoziol
as code owners
mattjala
requested review from
bmribler,
brtnfld,
glennsong09 and
vchoi-hdfgroup
as code owners
hyoklee
reviewed
Dec 11, 2025
hyoklee
approved these changes
Dec 12, 2025
bmribler
requested changes
Dec 17, 2025
|
|
||
| if (opts->contents == 0 && !opts->mode_verbose) { | ||
| printf("Files do not have the same set of objects.\n"); | ||
| printf("Use -v for a list of objects.\n"); |
Collaborator
There was a problem hiding this comment.
Do you know whether "a list of objects" means objects in both files or just one file and, if so, which one and should it be both? If it should be both, then it can be a separate issue.
Contributor
Author
There was a problem hiding this comment.
The -v option prints a list of the objects in both of the files and indicates which ones are not shared between the two files. I don't think the -v option needs any changes - what specific change are you requesting?
github-project-automation
bot
moved this from To be triaged
to In progress
in HDF5 - TRIAGE & TRACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h5diffsilently returns an error code of 1 whenever the two provided files differ structurally (one contains an object the other does not, different total object count). This PR adds a message indicating that the two files do not contain the same object set.Resolves #6102
Important
Add message in
h5diffto indicate when files do not have the same set of objects, with updates to expected test outputs.print_info()inh5diff_common.cwhen files differ structurally andopts->contentsis 0, suggesting to use-vfor more details.h5diff_11.txtandh5diff_13.txtto include new message about differing object sets.This description was created by
for 2a42195. You can customize this summary. It will automatically update as commits are pushed.