Skip to content

Add h5diff message about file object difference #6103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattjala wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −0
Open

Add h5diff message about file object difference #6103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c39de0
Add h5diff message about file object difference
mattjala Dec 11, 2025
2a42195
Correct reference files
mattjala Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/src/h5diff/h5diff_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,11 @@ print_info(diff_opt_t *opts)
printf("Use -c for a list of objects.\n");
}
}

if (opts->contents == 0 && !opts->mode_verbose) {
printf("Files do not have the same set of objects.\n");
printf("Use -v for a list of objects.\n");
Copy link
Collaborator

@bmribler bmribler Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know whether "a list of objects" means objects in both files or just one file and, if so, which one and should it be both? If it should be both, then it can be a separate issue.

Copy link
Contributor Author

@mattjala mattjala Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -v option prints a list of the objects in both of the files and indicates which ones are not shared between the two files. I don't think the -v option needs any changes - what specific change are you requesting?

}
}

/*-------------------------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions tools/test/h5diff/expected/h5diff_11.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
dataset: </g1/dset1> and </g1/dset1>
5 differences found
Files do not have the same set of objects.
Use -v for a list of objects.
2 changes: 2 additions & 0 deletions tools/test/h5diff/expected/h5diff_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ position dset1 dset1 difference
[ 1 1 ] 1 1.001 0.001
[ 2 1 ] 0 1 1
5 differences found
Files do not have the same set of objects.
Use -v for a list of objects.
Loading