Update library context symbol names for HDF5 2.0.0 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #else | ||
| #define FUNC_H5VLOPEN_LIB_CONTEXT H5VLstart_lib_state | ||
| #define FUNC_H5VLCLOSE_LIB_CONTEXT H5VLfinish_lib_state | ||
| #define FUNC_H5VLOPEN_LIB_CONTEXT H5VLopen_lib_context |
There was a problem hiding this comment.
Shouldn't this already be handled above due to #if H5_VERSION_GE(2, 0, 0)? It looks like this #else case is already in place for handling older versions of HDF5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HDF5 2.0.0,
H5VLstart_lib_statewas renamed toH5VLopen_lib_context, andH5VLfinish_lib_statewas renamed toH5VLclose_lib_context