Skip to content

Update library context symbol names for HDF5 2.0.0 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update library context symbol names for HDF5 2.0.0 #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/h5_async_vol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@ works, and perform publicly and display publicly, and to permit others to do so.
#define FUNC_H5VLOPEN_LIB_CONTEXT_STR "H5VLopen_lib_context"
#define FUNC_H5VLCLOSE_LIB_CONTEXT_STR "H5VLclose_lib_context"
#else
#define FUNC_H5VLOPEN_LIB_CONTEXT H5VLstart_lib_state
#define FUNC_H5VLCLOSE_LIB_CONTEXT H5VLfinish_lib_state
#define FUNC_H5VLOPEN_LIB_CONTEXT H5VLopen_lib_context
Copy link

@jhendersonHDF jhendersonHDF Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this already be handled above due to #if H5_VERSION_GE(2, 0, 0)? It looks like this #else case is already in place for handling older versions of HDF5.

#define FUNC_H5VLCLOSE_LIB_CONTEXT H5VLclose_lib_context
#define H5VLOPEN_LIB_CONTEXT(CONTEXT) FUNC_H5VLOPEN_LIB_CONTEXT()
#define H5VLCLOSE_LIB_CONTEXT(CONTEXT) FUNC_H5VLCLOSE_LIB_CONTEXT()
#define FUNC_H5VLOPEN_LIB_CONTEXT_STR "H5VLstart_lib_state"
#define FUNC_H5VLCLOSE_LIB_CONTEXT_STR "H5VLfinish_lib_state"
#define FUNC_H5VLOPEN_LIB_CONTEXT_STR "H5VLopen_lib_context"
#define FUNC_H5VLCLOSE_LIB_CONTEXT_STR "H5VLclose_lib_context"
#endif

FILE *fout_g;
Expand Down
Loading