Add support for rgb control via lamp array (windows dynamic lighting)#49
Open
saad-script wants to merge 6 commits intoHandHeldLegend:masterfrom
Open
Add support for rgb control via lamp array (windows dynamic lighting)#49saad-script wants to merge 6 commits intoHandHeldLegend:masterfrom
saad-script wants to merge 6 commits intoHandHeldLegend:masterfrom
Conversation
Author
|
Also another note, though this PR seems pretty big (+500), most of that is from the The actual logic which is in |
Contributor
There was a problem hiding this comment.
Suggestion; for the width/height/depth, this should be standardized to a mm metric unit, or if it already is mm, just label it as such for clarity.
Author
There was a problem hiding this comment.
Sure, ill add in a comment here.
According to the specs its standardized to micrometers
(section 3.1 of the linked spec document has more info regarding this coordinate system)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the lamp array protocol, commonly referred to as Windows Dynamic Lighting support. It’s important to note, however, that the protocol itself is open and not restricted to Windows. The spec can be found here.
Changes made:
added in a new animation mode
RGB_ANIM_EXTERNAL.Added in lamp array protocol:
lamp_array.handlamp_array.cdefine all the behavior that follows the spec linked above.Should be noted that this is only applied to sinput mode.
Tested and confirmed to work with windows dynamic lighting. Though it should be noted that for more advanced rgb effects, like rainbow waves, or gradients, the
board_config.hof the target should define the device dimensions and rgb lamp locations. Simple rgb color control will work either way, but without the lamp location info, the advanced effects will not look accurate.I already added the dimension and lamp position info into all the progcc targets (3, 3.1, 3.2).
I PRed this into the parent repo: HandHeldLegend/hoja-device-fw#7
I can add this positional info for all the other targets if this PR is something you would want to move forward with.