Skip to content

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Jun 14, 2025

@Pepper0ni
Copy link
Contributor

Pepper0ni commented Jun 15, 2025

I'm a bit reluctant to remove size only, as in theory it should have use as a "good or not" indicator with less info attached than fill CMC, but do know it can be a logical troublemaker due to collision differences, plus the small key thing brought up before...

Maybe a "gilded only" setting would be a practical replacement, then everything with a junk texture, as well as skulls, could be "junk" and everything else would be gilded?

EDIT: another issue I've had brought up to me is mods which don't have proper chest setups might need size as a fallback, I'm less familiar with this issue though as I don't get involved in the modding side

@serprex
Copy link
Contributor Author

serprex commented Jun 15, 2025

There was talk of pulling back features, which resulted in cutting some link animations from pause menu & potion values. This seemed like a candidate to cull. The extra information seems fine, especially since it's more interesting to gate behind stone. But maybe this could creep further & we could have gilded only be upped to full texturing with stone of agony (could handle this in settings by storing CSMC type on both csmc option itself & chests of agony, also opens up troll options like csmc enabled & stone of agony disabling csmc..)

Mod issue might explain why 5523 had settings on size only. Perhaps we can agree that size can be removed once mod compat is worked out

In meantime I'll split this PR in 2: #5588

@serprex serprex marked this pull request as draft June 15, 2025 13:15
@serprex serprex force-pushed the heart-chest branch 2 times, most recently from 609949c to 6d25c57 Compare November 24, 2025 12:41
@serprex serprex changed the title Add heart chest texture from 2ship. Remove size matches contents option Remove size matches contents option Nov 24, 2025
@serprex serprex force-pushed the heart-chest branch 2 times, most recently from fca8954 to d653ee9 Compare November 24, 2025 12:57
@serprex
Copy link
Contributor Author

serprex commented Jan 3, 2026

replaced by #6085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants