-
Notifications
You must be signed in to change notification settings - Fork 631
Update CSMC to CMC and update chests to other shuffles #6085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2026
Contributor
|
Please pull in from #5586 additional changes (some comments being updated / code removal) |
serprex
reviewed
Jan 3, 2026
serprex
reviewed
Jan 3, 2026
serprex
reviewed
Jan 3, 2026
Contributor
Author
|
I didnt git pull that branch but i did go through and manually added the changes from #5586 |
Contributor
Author
|
I think I got everything that have been reviewed and suggested now |
serprex
added a commit
to serprex/Shipwright
that referenced
this pull request
Jan 4, 2026
replaced in HarbourMasters#6085
serprex
added a commit
to serprex/Shipwright
that referenced
this pull request
Jan 4, 2026
replaced in HarbourMasters#6085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CSMC and removed the option for size as that was only used by chests.
Implemented unique DL's chest parts for CMC to use. They are based on whats used in 2ship
These DL will overwrite modded chests. So mod compability is gonna be fixed for this as the specific CMC dls can be modded as its own DL
Included are dls for
Major (Gold Rim), Lesser (Silver Rim), Junk (Bronze Rim), Skulltoken, Heart and key. Boss key chests uses the original bosskey chest DL. Mask and fairy is included incase of ootxmm.
Build Artifacts