Sync with latest effect #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey there @joepjoosten ! Thank you very much for all your work! This library definitely needs some love at some point in the future, but I just don't have the time to put into it at the moment, so I appreciate your work! Once CI is passing I'll happily merge! |
Contributor
Author
|
That great! I've fixed the remaining issue, Either generic parameter reversal, and it should now build correctly and all the tests are passing. |
IMax153
requested changes
Dec 3, 2024
Owner
|
Also seems to be a linting failure in the recently introduced circular.js file. |
Owner
|
@joepjoosten - CI is failing on the docgen step. For now, I would suggest we just remove the docs step from CI. |
Owner
|
Thanks for your work @joepjoosten |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Max,
I've taken the liberty to update this package to the latest effect. Including the dependencies (i've taken a look at effect-ts).
I've been using https://github.com/gcanti/parser-ts in the past, so i'm hoping to use this during the advent of code 2024 (i'm already two days behind...)
Hopefully this can be merged.
I'll be using it for the advent of code, and when i run into problems, I'll report it here, and will also try to fix it.
Regards,
Joep