Skip to content

Fix GET /settings/name 500 error #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qqmyers wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −2
Open

Fix GET /settings/name 500 error #12239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/edu/harvard/iq/dataverse/api/Admin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,8 @@

String content = settingsSvc.get(name);
return (content != null) ? ok(content) : notFound("Setting " + name + " not found.");
} catch (IllegalArgumentException iae) {
return error(Response.Status.BAD_REQUEST, iae.getMessage());
} catch (SettingsValidationException sve) {
return error(Response.Status.BAD_REQUEST, sve.getMessage());
}
}

Expand All @@ -299,7 +299,7 @@
settingsSvc.delete(name);
return ok("Setting " + name + " deleted.");
} catch (SettingsValidationException sve) {
return error(Response.Status.BAD_REQUEST, sve.getMessage());

Check warning

Code scanning / CodeQL

Information exposure through an error message Medium

Error information
Loading
can be exposed to an external user.
}
}

Expand Down
Loading