ScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring#167
Merged
ScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring#167
ScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring#167Conversation
ScheduleForm, TemplateForm, and TimeFrameForm Refactoring
yhabteab
requested changes
Dec 9, 2022
Member
yhabteab
left a comment
There was a problem hiding this comment.
That's still being used though!
icingaweb2-module-reporting/library/Reporting/Web/Controller.php
Lines 12 to 19 in 1760080
lippserd
requested changes
Jan 30, 2023
bca0436 to
d871ba4
Compare
ScheduleForm, TemplateForm, and TimeFrameForm RefactoringScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring
eb50d97 to
2801c05
Compare
added 5 commits
February 1, 2023 12:27
…()` as a static factory method
…omReport()` as a static factory method
…fromTemplate()` as a static factory method
…()` as a static factory method
lippserd
approved these changes
Feb 2, 2023
Member
|
@yhabteab Do you want to have a final look here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the Multiple Submit Buttons Hacks from
ScheduleForm,ReportForm,TemplateForm, andTimeFrameForm. it also adds PHPDocs and Typo annotation where possible.fixes #164