feat: Remove baseline from compose lint plugin#738
Merged
Conversation
PR Reviewer Guide 🔍(Review updated until commit b6a5b65)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
sirambd
requested changes
Apr 2, 2026
LunarX
force-pushed
the
remove-baseline-from-compose-lint-plugin
branch
from
de23833 to
6a747d8
Compare
|
Persistent review updated to latest commit 6a747d8 |
PR Code Suggestions ✨No code suggestions found for the PR. |
LunarX
force-pushed
the
remove-baseline-from-compose-lint-plugin
branch
from
6a747d8 to
6b3bc6d
Compare
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit b6a5b65 |
PR Code Suggestions ✨No code suggestions found for the PR. |
LunarX
force-pushed
the
remove-baseline-from-compose-lint-plugin
branch
from
b6a5b65 to
f8024cb
Compare
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Compose lint setup so baselines are no longer configured globally by the composeLint build-logic plugin, and removes many module-level empty baseline files—keeping baselines only in modules that actually need them.
Changes:
- Remove
baselineconfiguration fromComposeLintPluginso it no longer forces every Android subproject to uselint-baseline.xml. - Delete numerous empty
lint-baseline.xmlfiles across modules. - Add per-module
lint { baseline = file("lint-baseline.xml") }only for modules that still require a baseline.
Reviewed changes
Copilot reviewed 50 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| build.gradle.kts | Adds lint baseline configuration for the root module. |
| build-logic/composeLint/src/main/kotlin/com/infomaniak/core/compose/lint/ComposeLintPlugin.kt | Stops auto-configuring lint baseline for every Android subproject. |
| WebView/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/View/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/View/EdgeToEdge/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/Compose/Theme/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/Compose/Preview/build.gradle.kts | Adds module lint baseline configuration. |
| Ui/Compose/MaterialThemeFromXml/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/Compose/Margin/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/Compose/BottomStickyButtonScaffolds/build.gradle.kts | Adds module lint baseline configuration. |
| Ui/Compose/Basics/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/Compose/BasicButton/lint-baseline.xml | Removes empty lint baseline file. |
| Ui/Compose/AccountBottomSheet/lint-baseline.xml | Removes empty lint baseline file. |
| TwoFactorAuth/Front/build.gradle.kts | Adds module lint baseline configuration. |
| TwoFactorAuth/Back/lint-baseline.xml | Removes empty lint baseline file. |
| TwoFactorAuth/Back/WithUserDb/lint-baseline.xml | Removes empty lint baseline file. |
| Thumbnails/lint-baseline.xml | Removes empty lint baseline file. |
| SharedValues/lint-baseline.xml | Removes empty lint baseline file. |
| Sentry/lint-baseline.xml | Removes empty lint baseline file. |
| RecyclerView/lint-baseline.xml | Removes empty lint baseline file. |
| PrivacyManagement/lint-baseline.xml | Removes empty lint baseline file. |
| Onboarding/build.gradle.kts | Adds module lint baseline configuration. |
| Notifications/lint-baseline.xml | Removes empty lint baseline file. |
| Notifications/Registration/lint-baseline.xml | Removes empty lint baseline file. |
| Network/lint-baseline.xml | Removes empty lint baseline file. |
| Network/Models/lint-baseline.xml | Removes empty lint baseline file. |
| Network/Ktor/lint-baseline.xml | Removes empty lint baseline file. |
| Matomo/lint-baseline.xml | Removes empty lint baseline file. |
| Legacy/lint-baseline.xml | Removes empty lint baseline file. |
| Legacy/Confetti/lint-baseline.xml | Removes empty lint baseline file. |
| Ktor/lint-baseline.xml | Removes empty lint baseline file. |
| KSuite/lint-baseline.xml | Removes empty lint baseline file. |
| KSuite/MyKSuite/build.gradle.kts | Adds module lint baseline configuration. |
| KSuite/KSuitePro/build.gradle.kts | Adds module lint baseline configuration. |
| InAppUpdate/build.gradle.kts | Adds module lint baseline configuration. |
| InAppReview/lint-baseline.xml | Removes empty lint baseline file. |
| FragmentNavigation/lint-baseline.xml | Removes empty lint baseline file. |
| FileTypes/lint-baseline.xml | Removes empty lint baseline file. |
| File/lint-baseline.xml | Removes empty lint baseline file. |
| DotLottie/lint-baseline.xml | Removes empty lint baseline file. |
| CrossAppLogin/Front/build.gradle.kts | Adds module lint baseline configuration. |
| CrossAppLogin/Back/lint-baseline.xml | Removes empty lint baseline file. |
| Common/lint-baseline.xml | Removes empty lint baseline file. |
| Coil/lint-baseline.xml | Removes empty lint baseline file. |
| BugTracker/lint-baseline.xml | Removes empty lint baseline file. |
| Avatar/lint-baseline.xml | Removes empty lint baseline file. |
| Auth/lint-baseline.xml | Removes empty lint baseline file. |
| AppVersionChecker/lint-baseline.xml | Removes empty lint baseline file. |
| AppLock/lint-baseline.xml | Removes empty lint baseline file. |
| AppIntegrity/lint-baseline.xml | Removes empty lint baseline file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Failed to generate code suggestions for PR |
LunarX
force-pushed
the
remove-baseline-from-compose-lint-plugin
branch
from
31768c7 to
8f2e395
Compare
|
Failed to generate code suggestions for PR |
sirambd
approved these changes
Apr 27, 2026
…pose" This reverts commit 6b3bc6d.
LunarX
force-pushed
the
remove-baseline-from-compose-lint-plugin
branch
from
8f2e395 to
9f4a09c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most modules don't need a baseline because it would simply be empty. Also creating a new module would require to generate an empty baseline for no reason. Now baselines are only defined inside of the few modules that actually need one