Skip to content

feat: Improve spam snackbar text#2887

Merged
solrubado merged 4 commits intomainfrom
improve-spam-snackbar-text
Apr 28, 2026
Merged

feat: Improve spam snackbar text#2887
solrubado merged 4 commits intomainfrom
improve-spam-snackbar-text

Conversation

@solrubado
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 27, 2026 15:11
@solrubado solrubado changed the title Improve spam snackbar text feat: Improve spam snackbar text Apr 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the move-to-folder snackbar messaging to use dedicated “moved to Spam” strings (including plural forms) when the destination folder is Spam.

Changes:

  • Add new snackbarMessageMovedToSpam and snackbarThreadMovedToSpam string resources across multiple locales.
  • Update MainViewModel.showMoveSnackbar() to switch snackbar text based on whether the destination folder role is SPAM.
  • Refactor snackbar title construction into helper methods for threads vs. single message moves.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
app/src/main/res/values/strings.xml Adds new default-locale Spam snackbar string + plurals.
app/src/main/res/values-sv/strings.xml Adds Swedish Spam snackbar string + plurals.
app/src/main/res/values-pt/strings.xml Adds Portuguese Spam snackbar string + plurals.
app/src/main/res/values-pl/strings.xml Adds Polish Spam snackbar string + plurals (with few/many).
app/src/main/res/values-nl/strings.xml Adds Dutch Spam snackbar string + plurals.
app/src/main/res/values-nb/strings.xml Adds Norwegian Bokmål Spam snackbar string + plurals.
app/src/main/res/values-it/strings.xml Adds Italian Spam snackbar string + plurals.
app/src/main/res/values-fr/strings.xml Adds French Spam snackbar string + plurals.
app/src/main/res/values-fi/strings.xml Adds Finnish Spam snackbar string + plurals.
app/src/main/res/values-es/strings.xml Adds Spanish Spam snackbar string + plurals.
app/src/main/res/values-el/strings.xml Adds Greek Spam snackbar string + plurals.
app/src/main/res/values-de/strings.xml Adds German Spam snackbar string + plurals.
app/src/main/res/values-da/strings.xml Adds Danish Spam snackbar string + plurals.
app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt Chooses Spam-specific snackbar text when destination role is Spam and extracts helpers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/main/res/values/strings.xml
Comment thread app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt
Comment thread app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt Outdated
Comment thread app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt Outdated
Comment thread app/src/main/res/values/strings.xml
@solrubado solrubado force-pushed the improve-spam-snackbar-text branch from 56370b9 to c4b1f78 Compare April 27, 2026 15:27
@solrubado solrubado force-pushed the improve-spam-snackbar-text branch from f5e9d15 to 86f16ce Compare April 28, 2026 08:02
@sonarqubecloud
Copy link
Copy Markdown

@solrubado solrubado merged commit b2ad707 into main Apr 28, 2026
7 checks passed
@solrubado solrubado deleted the improve-spam-snackbar-text branch April 28, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants