Conversation
|
|
||
| - Editing the List of Avatars | ||
| - Why it may change: We'll continuously add, delete, or update more avatars as more games roll in. | ||
| - How it is isolated: We'll have a system that allows us to perform this action. |
There was a problem hiding this comment.
What exactly do you mean "a system"? How does that translate to code?
There was a problem hiding this comment.
Ahh, I mean a dedicated service for my website that allows us to upload new avatars and edit or remove existing ones.
There was a problem hiding this comment.
That makes sens! I think a service is a nice solution here.
rachelkingCPTC
left a comment
rachelkingCPTC
left a comment
There was a problem hiding this comment.
You all should feel great about how you did the analysis for this assignment. Really excellent ideas. However, part of this assignment was implementing those ideas. Especially in a group of 3, I expected to see heavy code changes. From the assignment doc:
Each team member should take at least two variabilities separately and develop a strategy to isolate it
- Make any needed changes to code
| ## Variabilities | ||
| - Game catalogue | ||
| - Why it may change: Games will be constantly added, updated, and removed. | ||
| - How it is isolated: Only certain users with certain privileges will add, update, and remove games. |
There was a problem hiding this comment.
I wouldn't say this isolates the variability you described. Which code strategy will you use to make it so that adding and removing a new game will be an easy change to make?
|
|
||
| - Contact Support | ||
| - Why it may change: As the platform grows, we may get a better support system that allows a user to get a support ticket. | ||
| - How it is isolated: We would make our own support service. |
There was a problem hiding this comment.
Awesome! I think a ContactSupportService is a great idea, because it will touch many entities. I don't see the implementation in this PR.
|
|
||
| - Amount of achievements | ||
| - Why it may change: Developers can add content that will also contain achievements players can earn rewards. | ||
| - How it is isolated: Modify the achievement system in that specific game (presumably `achievement.js`). |
|
|
||
| - Editing the List of Avatars | ||
| - Why it may change: We'll continuously add, delete, or update more avatars as more games roll in. | ||
| - How it is isolated: We'll have a dedicated service for admins that allows us to perform this action. |
There was a problem hiding this comment.
Same comment: not evidenced in this PR.
|
|
||
| - User Permission/Role Policies | ||
| - Why it may change: New roles sch as admin/moderator as well as developer may be added, permissions may shift as platform grows | ||
| - How it is isolated: A permissionPolicy object to define role capabilities |
There was a problem hiding this comment.
This is a really nice idea for the use of a policy object. I think it gives you much more flexibility than having all these roles being different classes. But, same comment: not implemented in this PR.
|
|
||
| - Functionality of the Search Engine | ||
| - Why it may change: As the library grows, there will be a more robust way to find results. | ||
| - How it is isolated: We optimize the code to use better O Notation for searches. No newline at end of file |
2 participants
This is the group work project for Assignment 4