CPW 207 Assignment 4 (Interlinked Team) #59
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| { | ||
| "games": [ | ||
| { | ||
| "name": "Super Smash Bros", | ||
| "description": "Test entry for update script", | ||
| "tags": ["fighting", "test"], | ||
| "folderName": "super-smash-bros", | ||
| "repo": "https://github.com/ToastedToast00/Super-Smash-Bros" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Commonality and Variability Analysis | ||
|
|
||
| ## Commonalities | ||
| - User must register on the site to access certain features. | ||
| - Users can form friendships with other users. | ||
| - Users can complete achievements and receive rewards. | ||
| - The user is a central actor for the site. | ||
| - The user is able to search for games using the built-in search engine. | ||
| - An achievement belongs to a game and has completion criteria. | ||
|
|
||
| ## Variabilities | ||
| - Game catalogue | ||
| - Why it may change: Games will be constantly added, updated, and removed. | ||
| - How it is isolated: Only certain users with certain privileges will add, update, and remove games. | ||
|
|
||
| - Contact Support | ||
| - Why it may change: As the platform grows, we may get a better support system that allows a user to get a support ticket. | ||
| - How it is isolated: We would make our own support service. | ||
|
There was a problem hiding this comment. Awesome! I think a |
||
|
|
||
| - Amount of achievements | ||
| - Why it may change: Developers can add content that will also contain achievements players can earn rewards. | ||
| - How it is isolated: Modify the achievement system in that specific game (presumably `achievement.js`). | ||
|
|
||
|
|
||
| - Editing the List of Avatars | ||
| - Why it may change: We'll continuously add, delete, or update more avatars as more games roll in. | ||
| - How it is isolated: We'll have a dedicated service for admins that allows us to perform this action. | ||
|
There was a problem hiding this comment. Same comment: not evidenced in this PR. |
||
|
|
||
| - User Permission/Role Policies | ||
| - Why it may change: New roles sch as admin/moderator as well as developer may be added, permissions may shift as platform grows | ||
| - How it is isolated: A permissionPolicy object to define role capabilities | ||
|
There was a problem hiding this comment. This is a really nice idea for the use of a policy object. I think it gives you much more flexibility than having all these roles being different classes. But, same comment: not implemented in this PR. |
||
|
|
||
| - Website Themes | ||
| - Why it may change: Sometimes the coloring may be off, or we'll add more themes. | ||
| - How it is isolated: Have a new .theme.css file for each theme. | ||
|
|
||
| - Functionality of the Search Engine | ||
| - Why it may change: As the library grows, there will be a more robust way to find results. | ||
| - How it is isolated: We optimize the code to use better O Notation for searches. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't say this isolates the variability you described. Which code strategy will you use to make it so that adding and removing a new game will be an easy change to make?