Final updates of develop from release 1.9.3#1790
Conversation
| wgrib2: | ||
| require: | ||
| - '@3.6.0' | ||
| - '+ipolates +netcdf' |
There was a problem hiding this comment.
While building wgrib2 this way "works" (see: JCSDA/spack#561), wgrib2/package.py ought to be properly fixed.
There was a problem hiding this comment.
Good point, see the CI failure: https://github.com/JCSDA/spack-stack/actions/runs/18286538992/job/52062910954
@AlexanderRichert-NOAA @rickgrubin-noaa What is the permanent fix? Will that be made for spack-packages only i.e. do we bring over the temporary fix from the spack submodule release/1.9.0 branch for the time being?
There was a problem hiding this comment.
@rickgrubin-noaa I've decided to pull in your temporary fix for the reasons stated in JCSDA/spack#568. I assume this hasn't been fixed yet in the new spack-packages repo?
There was a problem hiding this comment.
@rickgrubin-noaa I've decided to pull in your temporary fix for the reasons stated in JCSDA/spack#568. I assume this hasn't been fixed yet in the new spack-packages repo?
This has not been fixed in the new spack-packages repo.
As far as I can tell (and @AlexanderRichert-NOAA certainly understand better than I), the temporary fix implemented for v3.6.0 isn't necessarily applicable for other, earlier versions. I have not looked into it further.
…from_rel193 Cherry-picking 30eb08b from release/1.9.0 for develop to fix the CI build errors discussed in JCSDA/spack-stack#1790 (comment). This is the same as PR #561 that went into release/1.9.0, but updated to match the correct wgrib2 versions.
Description
Final round of updates from release 1.9.3 (branch
release/1.9.0) for develop. An attempt will be made to pull these updatesinto the newfeature/update_to_spack_v1branch for changes that are not related to site configs, and for site configs that haven't been updated yet to work with spack v1. This will be a follow-up PR titled "Update feature/update_to_spack_v1 from develop".Dependencies
Issues addressed
Closes #1694
Closes #1760
Applications affected
None (all changes already deployed as part of spack-stack-1.9.3)
Systems affected
None (all changes already deployed as part of spack-stack-1.9.3)
Testing
Checklist
doc/source/PreConfiguredSites.rstanddoc/source/MaintainersSection.rstAll necessary updates to the spack-stack wiki will be made when this PR is mergeddeferred