Merged
Conversation
climbfuji
changed the title
findESMF.cmake starting from this version
7 tasks
climbfuji
commented
Apr 4, 2025
| python_builder = PythonPipBuilder(pkg) | ||
| python_builder.install(pkg, spec, prefix) | ||
|
|
||
| if spec.satisfies("@8.9:"): |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| if spec.satisfies("@8.9:"): | |
| # Install findESMF.cmake | |
| if spec.satisfies("@8.9:"): |
theurich
reviewed
Apr 4, 2025
Collaborator
theurich
left a comment
theurich
left a comment
There was a problem hiding this comment.
Have a question for my own understanding. Thanks.
climbfuji
changed the title
findESMF.cmake starting from this version
climbfuji
force-pushed
the
feature/esmf89
branch
from
ea2ca37 to
4b4fe88
Compare
github-project-automation
bot
moved this from In Progress
to Done
in spack-stack-2.0.x (2025 Q4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add esmf@8.9.0b05 and install ESMF's
findESMF.cmakestarting from this version. The former is required for recent NEPTUNE development (ESMX integration), the latter to removefindESMF.cmakefromCMakeModulesand various other places in order to always use the authoritativefindESMF.cmake. See also NOAA-EMC/CMakeModules#71Testing
esmf@8.9.0b05on my dev machine and verified that a simpleCMakeLists.txtchange is picking up the correctfindESMF.cmakefile: