Remove Modules/FindESMF.cmake - use ESMF's own version

[climbfuji]

Description

Remove Modules/FindESMF.cmake - ESMF has its own, developer-blessed version that we should use and that provides a switch for the user to use the static or shared library.

There will be changes needed for the applications and for the ESMF build (have the build system add /path/to/esmf-install/cmake to CMAKE_MODULES_PATH)

For spack builds, I created an issue here: spack/spack#43575

I will keep this in draft mode until we've prepared the updates for the build systems and tested with at least ufs-weather-model and jedi-ufs.

This resolves #70

[climbfuji]

@aerorahul @DusanJovic-NOAA Is it ok to merge this?

The UFS can continue to point to older versions of CMakeModules (current hash) until it is ready to move up.

NEPTUNE needs to make the switch to leverage the updated findESMF.cmake that ships with esmf@8.9.0b05.

Thanks!

[DusanJovic-NOAA]

@climbfuji I still have a branch and PR open for ufs-weather-model which removes all local copies of FindESMF.cmake from various submodules and uses FindESMF.cmake that comes with ESMF installation. It's very out-of-sync with all upstream branches and due to many other issues with ESMF/MAPL recently I did not keep it up-to-date.

So, I guess it's ok to remove it.

@aerorahul What do you think?

[aerorahul]

@climbfuji
I am ok w. this merge.
@DusanJovic-NOAA
We should move to using FindESMF.cmake from ESMF installation. I think moving ahead with your PR is a good thing.

[climbfuji]

I am making this change for NEPTUNE (top-level CMakeLists.txt):

list(APPEND CMAKE_MODULE_PATH $ENV{esmf_ROOT}/cmake)
find_package(ESMF 8.9.0 MODULE REQUIRED)

The corresponding update for the spack install recipe is JCSDA/spack#532 - apologies for not filling out the template yet, but wanted to give you a chance to look at it.

[theurich]

Looks like the right next step.

[climbfuji]

@aerorahul Once this is merged, would you be able to create another tag of this repo, please?

[climbfuji]

Gentle reminder ... is it possible to merge this, please, and maybe create a tag (optional) afterwards? Thanks very much!

[aerorahul]

lgtm

[aerorahul]

@climbfuji Done.
https://github.com/NOAA-EMC/CMakeModules/releases/tag/v1.4.0 released

[climbfuji]

@climbfuji Done. https://github.com/NOAA-EMC/CMakeModules/releases/tag/v1.4.0 released

Thanks very much @aerorahul, appreciate it!