This repository was archived by the owner on Sep 10, 2020. It is now read-only.
Fix referencing TileService on older devices.#172
Open
NightlyNexus wants to merge 2 commits intoJakeWharton:masterfrom
Open
Fix referencing TileService on older devices.#172NightlyNexus wants to merge 2 commits intoJakeWharton:masterfrom
NightlyNexus wants to merge 2 commits intoJakeWharton:masterfrom
Conversation
NightlyNexus
commented
Feb 9, 2018
| interface Component { | ||
| void inject(TelecineApplication app); | ||
|
|
||
| DispatchingAndroidInjector<Service> injector(); |
Contributor
Author
There was a problem hiding this comment.
this is such a neat trick that Ron pointed out!
NightlyNexus
commented
Feb 9, 2018
| } | ||
|
|
||
| @dagger.Module | ||
| abstract class Module { |
Contributor
Author
There was a problem hiding this comment.
this is the saddest part i see. this module is unused, and i don't know if there's anything to do about it.
Contributor
Author
There was a problem hiding this comment.
actually, let's not reference the generated module?
Contributor
Author
There was a problem hiding this comment.
(i used to be doing @Subcomponent(modules = TelecineTileService_Module_ContributeTelecineTileService.class).)
Use a different component for 24+, and only reference this component on 24+.
NightlyNexus
force-pushed
the
eric.2018-02-08.fixy
branch
from
72b7a51 to
3c15a28
Compare
And shuffle code.
Contributor
Author
|
for future searchers, you can use strings instead of classes for the keys as of Dagger 2.17 with the flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a different component for 24+, and only reference this component on 24+.
Fixes #166.