Skip to content

hc/update_PrettyTables#540

Closed
hannahchubin wants to merge 2 commits intoJuliaStats:masterfrom
hannahchubin:master
Closed

hc/update_PrettyTables#540
hannahchubin wants to merge 2 commits intoJuliaStats:masterfrom
hannahchubin:master

Conversation

@hannahchubin
Copy link

I updated PrettyTables to version 3.1.0 and all the tests in test/runtests.jl are passing. I am trying to update PrettyTables in some other repos that also depend on TimeSeries, which is currently limiting the PrettyTables version to less than v3.0.0.

@iblislin
Copy link
Collaborator

hmm any idea about the CI failure?

@hannahchubin
Copy link
Author

hannahchubin commented Nov 13, 2025

hmm any idea about the CI failure?

Wasn't sure if this question was aimed towards me, the only info I have about it is that it looks like this failure was happening on other PRs opened before mine. Is PR #541 meant to address the CI failure?

@briederer
Copy link
Contributor

#541 is only an issue to reactivate the github workflow again, that PRs like yours do not need to be made manually in the future (see #542).

I has a quick look at the CI output ofnyour PR and master and they are different.
The one on master should be actually fixed now since it was only to a missing compat in MarketData.jl (see JuliaQuant/MarketData.jl#105).

For your PR it seems that the _text__print_table(...) signature hast changed from PrettyTables v2 to v3. This needs to be fixed. I can have a quick look if you want.

briederer added a commit to briederer/TimeSeries.jl that referenced this pull request Nov 14, 2025
iblislin pushed a commit that referenced this pull request Nov 17, 2025
* Bump PrettyTables compat to v3 (related to #540

* Adapt to v3 of PrettyTables.jl

* Allow backwards compatibility to PrettyTables v2
@iblislin
Copy link
Collaborator

fixed by #543

@iblislin iblislin closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants