Skip to content

Upgrade to PrettyTables v3#543

Merged
iblislin merged 3 commits intoJuliaStats:masterfrom
briederer:master
Nov 17, 2025
Merged

Upgrade to PrettyTables v3#543
iblislin merged 3 commits intoJuliaStats:masterfrom
briederer:master

Conversation

@briederer
Copy link
Contributor

Adds compat for PrettyTables v3 as well as keeps the compat to v2.

Supersedes #540 and #542

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 36.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.45%. Comparing base (3291223) to head (fd8ccad).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/timearray.jl 36.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   85.44%   85.45%   +0.01%     
==========================================
  Files          11       13       +2     
  Lines         625      887     +262     
==========================================
+ Hits          534      758     +224     
- Misses         91      129      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@briederer
Copy link
Contributor Author

@hannahchubin and @iblislin
I think I fixed it, and kept the compat for v2 since a lot of packages are still using v2 of PrettyTables. However it is missing a test for v2 since I am not familiar enough with the github actions to add a test where we explicitly force PrettyTables to v2 e.g. via an import (import Pkg; Pkg.add(Pkg.PackageSpec(name="PrettyTables", version="2"))) before the test is run.

@briederer
Copy link
Contributor Author

Also formatter should be run on all files I guess, to fix the other CI, but if I do this here this PR will be cluttered with non-related changes.

@briederer
Copy link
Contributor Author

Friendly reminder

@iblislin
Copy link
Collaborator

However it is missing a test for v2 since I am not familiar enough with the github actions to add a test where we explicitly force PrettyTables to v2 e.g. via an import (import Pkg; Pkg.add(Pkg.PackageSpec(name="PrettyTables", version="2"))) before the test is run.

hmm, I'm fine if we just go without the testing of v2.

@iblislin iblislin merged commit e31d3fa into JuliaStats:master Nov 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants