Update opening device position from status requests#680
Open
mnaggatz wants to merge 3 commits intoJulius2342:masterfrom
Open
Update opening device position from status requests#680mnaggatz wants to merge 3 commits intoJulius2342:masterfrom
mnaggatz wants to merge 3 commits intoJulius2342:masterfrom
Conversation
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679
During live testing with a courtyard gate, a garage door and Somfy roller shutters, these opening devices could remain
unknownfor a long time after a Home Assistant restart.The heartbeat already sends status requests for all nodes when
heartbeat_load_all_states=True, butNodeUpdater.process_frame_status_request_notification()only applied position data fromGW_STATUS_REQUEST_NTFforBlindandDualRollerShutter. OtherOpeningDevicetypes such asGate,GarageDoorandRollerShutterignored the main parameter (MP,NodeParameter(0)) from the status request response.This updates generic
OpeningDeviceinstances from concrete status request MP values, while still ignoring unavailable values such asUNKNOWN/IGNORE. The specialized handling forBlindandDualRollerShutteris unchanged.Added regression tests for:
Gaterecovering fromUNKNOWNvia status request MP dataGarageDoorrecovering fromUNKNOWNvia status request MP data