Fix/clear motion state from status request#683
Open
mnaggatz wants to merge 4 commits intoJulius2342:masterfrom
Open
Fix/clear motion state from status request#683mnaggatz wants to merge 4 commits intoJulius2342:masterfrom
mnaggatz wants to merge 4 commits intoJulius2342:masterfrom
Conversation
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #682
Depends on #680
This PR builds on the status request OpeningDevice position update from #680. Please review/merge that PR first; after it lands, this branch can be rebased onto master so the diff only contains the motion-state cleanup.
During live testing with a Somfy roller shutter, the KLF200 sent a complete movement sequence for opening and closing. The final successful sequence included:
pyvlx currently clears
is_opening/is_closingwhen the finalGW_NODE_STATE_POSITION_CHANGED_NTFis processed. If that final DONE state frame is missed or delayed, Home Assistant can keep showing the cover asopening/closingeven though the physical movement has already completed.The heartbeat/status request path can later report the concrete final MP position together with
run_status=EXECUTION_COMPLETED. With the preceding status request position update, pyvlx already uses that MP value to recover the position. This PR also clears stale motion state from that completed status request.Changes:
OpeningDevicereceives a concreteNodeParameter(0)/ MP value fromFrameStatusRequestNotificationrun_status == RunStatus.EXECUTION_COMPLETEDis_opening/is_closingstate_received_at/estimated_completionRunStatus.EXECUTION_ACTIVE